aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorQingfang Deng <qingfang.deng@siflower.com.cn>2024-03-13 11:48:44 +0800
committerChuanhong Guo <gch981213@gmail.com>2024-03-16 15:30:03 +0800
commit503d26fb24cf980ed6d28cb080b0f81e8ba4e72d (patch)
tree14c449264b36cb9ebcabadb9e2da4c3785d3634a
parentfc9bde82f34eb81f9f639f9da8dd7369651d871b (diff)
kernel: xt_FLOWOFFLOAD: fix use of uninitialized dir variable
The dir variable has been used uninitialized since the port to 5.10, and somehow this remains undetected by GCC. Fixes: b10d6044599d ("kernel: add linux 5.10 support") Signed-off-by: Qingfang Deng <qingfang.deng@siflower.com.cn>
-rw-r--r--target/linux/generic/hack-5.15/650-netfilter-add-xt_FLOWOFFLOAD-target.patch4
-rw-r--r--target/linux/generic/hack-6.1/650-netfilter-add-xt_FLOWOFFLOAD-target.patch4
-rw-r--r--target/linux/generic/hack-6.6/650-netfilter-add-xt_FLOWOFFLOAD-target.patch4
3 files changed, 6 insertions, 6 deletions
diff --git a/target/linux/generic/hack-5.15/650-netfilter-add-xt_FLOWOFFLOAD-target.patch b/target/linux/generic/hack-5.15/650-netfilter-add-xt_FLOWOFFLOAD-target.patch
index da60334498..ec887539d5 100644
--- a/target/linux/generic/hack-5.15/650-netfilter-add-xt_FLOWOFFLOAD-target.patch
+++ b/target/linux/generic/hack-5.15/650-netfilter-add-xt_FLOWOFFLOAD-target.patch
@@ -609,6 +609,8 @@ Signed-off-by: Felix Fietkau <nbd@nbd.name>
+ if (!nf_ct_is_confirmed(ct))
+ return XT_CONTINUE;
+
++ dir = CTINFO2DIR(ctinfo);
++
+ devs[dir] = xt_out(par);
+ devs[!dir] = xt_in(par);
+
@@ -618,8 +620,6 @@ Signed-off-by: Felix Fietkau <nbd@nbd.name>
+ if (test_and_set_bit(IPS_OFFLOAD_BIT, &ct->status))
+ return XT_CONTINUE;
+
-+ dir = CTINFO2DIR(ctinfo);
-+
+ if (xt_flowoffload_route(skb, ct, par, &route, dir, devs) < 0)
+ goto err_flow_route;
+
diff --git a/target/linux/generic/hack-6.1/650-netfilter-add-xt_FLOWOFFLOAD-target.patch b/target/linux/generic/hack-6.1/650-netfilter-add-xt_FLOWOFFLOAD-target.patch
index 59a5fb4d91..1dfd556ce8 100644
--- a/target/linux/generic/hack-6.1/650-netfilter-add-xt_FLOWOFFLOAD-target.patch
+++ b/target/linux/generic/hack-6.1/650-netfilter-add-xt_FLOWOFFLOAD-target.patch
@@ -547,6 +547,8 @@ Signed-off-by: Felix Fietkau <nbd@nbd.name>
+ if (!nf_ct_is_confirmed(ct))
+ return XT_CONTINUE;
+
++ dir = CTINFO2DIR(ctinfo);
++
+ devs[dir] = xt_out(par);
+ devs[!dir] = xt_in(par);
+
@@ -556,8 +558,6 @@ Signed-off-by: Felix Fietkau <nbd@nbd.name>
+ if (test_and_set_bit(IPS_OFFLOAD_BIT, &ct->status))
+ return XT_CONTINUE;
+
-+ dir = CTINFO2DIR(ctinfo);
-+
+ if (xt_flowoffload_route(skb, ct, par, &route, dir, devs) < 0)
+ goto err_flow_route;
+
diff --git a/target/linux/generic/hack-6.6/650-netfilter-add-xt_FLOWOFFLOAD-target.patch b/target/linux/generic/hack-6.6/650-netfilter-add-xt_FLOWOFFLOAD-target.patch
index cb7ac007b1..1c75a2cf3d 100644
--- a/target/linux/generic/hack-6.6/650-netfilter-add-xt_FLOWOFFLOAD-target.patch
+++ b/target/linux/generic/hack-6.6/650-netfilter-add-xt_FLOWOFFLOAD-target.patch
@@ -547,6 +547,8 @@ Signed-off-by: Felix Fietkau <nbd@nbd.name>
+ if (!nf_ct_is_confirmed(ct))
+ return XT_CONTINUE;
+
++ dir = CTINFO2DIR(ctinfo);
++
+ devs[dir] = xt_out(par);
+ devs[!dir] = xt_in(par);
+
@@ -556,8 +558,6 @@ Signed-off-by: Felix Fietkau <nbd@nbd.name>
+ if (test_and_set_bit(IPS_OFFLOAD_BIT, &ct->status))
+ return XT_CONTINUE;
+
-+ dir = CTINFO2DIR(ctinfo);
-+
+ if (xt_flowoffload_route(skb, ct, par, &route, dir, devs) < 0)
+ goto err_flow_route;
+