diff options
| author | Rafał Miłecki <rafal@milecki.pl> | 2022-08-10 14:23:40 +0200 |
|---|---|---|
| committer | Rosen Penev <rosenp@gmail.com> | 2022-08-11 14:05:45 -0700 |
| commit | c9cba619898d7bf87fc8277e57b473923d912c32 (patch) | |
| tree | 7b45acdc4944350c7300391fc2c3509e54db271b /net | |
| parent | 5a2fa10d07ea187df66c4ccea4c0e6958de5dbcd (diff) | |
ksmbd-tools: append config from /var/run/config/ for runtime shares
Dynamically created shares shouldn't be stored in the /etc/config/
because of:
1. Flash wearing
2. Risk of inconsistent state on reboots
With this change all automation/hotplug.d scripts can store runtime in
the /var/run/config/samba. It's useful e.g. for USB drives that user
wants to be automatically shared.
Also: automated scripts should never call "uci [foo] commit" as that
could flush incomplete config. This problem also gets solved.
Identical feature was added to samba36 in the OpenWrt commit
5a59e2c059866 ("samba36: append config from /var/run/config/ for runtime
shares") but wasn't ported to ksmbd until now.
Cc: Jo-Philipp Wich <jo@mein.io>
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Diffstat (limited to 'net')
| -rw-r--r-- | net/ksmbd-tools/files/ksmbd.init | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/ksmbd-tools/files/ksmbd.init b/net/ksmbd-tools/files/ksmbd.init index 7c628e826..8758ed4ec 100644 --- a/net/ksmbd-tools/files/ksmbd.init +++ b/net/ksmbd-tools/files/ksmbd.init @@ -116,6 +116,7 @@ init_config() mkdir -p /var/etc/ksmbd config_load ksmbd + CONFIG_APPEND=1 UCI_CONFIG_DIR=/var/run/config config_load ksmbd config_foreach smb_header globals config_foreach smb_add_share share } |