diff options
| author | Paul Spooren <mail@aparcar.org> | 2020-08-09 13:19:25 -1000 |
|---|---|---|
| committer | Paul Spooren <mail@aparcar.org> | 2020-08-09 13:58:14 -1000 |
| commit | 30ea917518b4d0643e0e2aa21daa26f78290bbbf (patch) | |
| tree | 0c4f76ae8a01124761466a6263aca584344190f5 /net/mwan3 | |
| parent | 416dccf72a82b624c9f42f2f4a6553439721a49f (diff) | |
treewide: replace `which` with `command -v`
Fix shellcheck SC2230
> which is non-standard. Use builtin 'command -v' instead.
Once applied to everything concerning OpenWrt we can disable the busybox
feature `which` and save 3.8kB.
Signed-off-by: Paul Spooren <mail@aparcar.org>
Diffstat (limited to 'net/mwan3')
| -rw-r--r-- | net/mwan3/Makefile | 2 | ||||
| -rwxr-xr-x | net/mwan3/files/usr/sbin/mwan3track | 8 |
2 files changed, 5 insertions, 5 deletions
diff --git a/net/mwan3/Makefile b/net/mwan3/Makefile index 958c21061..6ae44ad35 100644 --- a/net/mwan3/Makefile +++ b/net/mwan3/Makefile @@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk PKG_NAME:=mwan3 PKG_VERSION:=2.8.12 -PKG_RELEASE:=1 +PKG_RELEASE:=2 PKG_MAINTAINER:=Florian Eckert <fe@dev.tdt.de> PKG_LICENSE:=GPL-2.0 diff --git a/net/mwan3/files/usr/sbin/mwan3track b/net/mwan3/files/usr/sbin/mwan3track index e112475ce..a4ced8255 100755 --- a/net/mwan3/files/usr/sbin/mwan3track +++ b/net/mwan3/files/usr/sbin/mwan3track @@ -23,19 +23,19 @@ if_down() { validate_track_method() { case "$1" in ping) - which ping 1>/dev/null 2>&1 || { + command -v ping 1>/dev/null 2>&1 || { $LOG warn "Missing ping. Please install iputils-ping package or enable ping util and recompile busybox." return 1 } ;; arping) - which arping 1>/dev/null 2>&1 || { + command -v arping 1>/dev/null 2>&1 || { $LOG warn "Missing arping. Please install iputils-arping package." return 1 } ;; httping) - which httping 1>/dev/null 2>&1 || { + command -v httping 1>/dev/null 2>&1 || { $LOG warn "Missing httping. Please install httping package." return 1 } @@ -45,7 +45,7 @@ validate_track_method() { } ;; nping-*) - which nping 1>/dev/null 2>&1 || { + command -v nping 1>/dev/null 2>&1 || { $LOG warn "Missing nping. Please install nping package." return 1 } |