aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNick Hainke <vincent@systemli.org>2021-01-26 14:42:31 +0100
committerNick Hainke <vincent@systemli.org>2021-01-26 14:47:28 +0100
commit213c694b752ba35eade93fd3c3a286eab9c35eec (patch)
tree34f53ad97cc7eceb105da632c676cdb9eb9de178
parent922e5b1a8bde4bddca2b0f4eb680a9bf1532db77 (diff)
collectd: snmp6 further improvements
Return with "-1" if parsing fails in read function. Reduce buffersize of splitstring function. Signed-off-by: Nick Hainke <vincent@systemli.org>
Diffstat
1 files changed, 4 insertions, 4 deletions
diff --git a/utils/collectd/patches/931-snmp6-add-ipv6-statistics.patch b/utils/collectd/patches/931-snmp6-add-ipv6-statistics.patch
index 8f50b0fe6..94bfbac59 100644
--- a/utils/collectd/patches/931-snmp6-add-ipv6-statistics.patch
+++ b/utils/collectd/patches/931-snmp6-add-ipv6-statistics.patch
@@ -155,7 +155,7 @@ Signed-off-by: Nick Hainke <vincent@systemli.org>
+int snmp_read(char *ifname) {
+ FILE *fh;
+ char buffer[1024];
-+ char *fields[16];
++ char *fields[2];
+ int numfields;
+ int currline = 0;
+ derive_t data[76];
@@ -178,17 +178,17 @@ Signed-off-by: Nick Hainke <vincent@systemli.org>
+ }
+
+ while (fgets(buffer, 1024, fh) != NULL) {
-+ numfields = strsplit(buffer, fields, 16);
++ numfields = strsplit(buffer, fields, 2);
+
+ if (numfields < 2)
-+ continue;
++ return -1;
+
+ data[currline++] = atoll(fields[1]);
+ }
+
+ fclose(fh);
+
-+ if (currline < 25) {
++ if (currline < 28) {
+ return -1;
+ }
+
Powered by cgit, Themed by Ted Yin.