diff options
| author | Ivan Nardi <12729895+IvanNardi@users.noreply.github.com> | 2022-01-27 10:59:35 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-01-27 10:59:35 +0100 |
| commit | 9dcc4a2334fa10d7d0a3c019ee35dfde4c06e044 (patch) | |
| tree | 35b2ab5ff342f5ea0398289bda1f8d8944190c5b /src/lib | |
| parent | 011ee3ecbd3ee98457fc58b454aa3d549910f280 (diff) | |
Kerberos, TLS, example: fix some memory errors (#1419)
Detected by oss-fuzz:
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=43823
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=43921
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=43925
Diffstat (limited to 'src/lib')
| -rw-r--r-- | src/lib/protocols/kerberos.c | 2 | ||||
| -rw-r--r-- | src/lib/protocols/tls.c | 3 |
2 files changed, 3 insertions, 2 deletions
diff --git a/src/lib/protocols/kerberos.c b/src/lib/protocols/kerberos.c index 98d919391..65b35838f 100644 --- a/src/lib/protocols/kerberos.c +++ b/src/lib/protocols/kerberos.c @@ -230,7 +230,7 @@ void ndpi_search_kerberos(struct ndpi_detection_module_struct *ndpi_struct, name_offset++; } - if(name_offset < packet->payload_packet_len - 1 && + if(name_offset < packet->payload_packet_len - 3 && packet->payload[name_offset+1] == 0x1b) { name_offset += 2; diff --git a/src/lib/protocols/tls.c b/src/lib/protocols/tls.c index 96ee3e6a2..1eefe2d0f 100644 --- a/src/lib/protocols/tls.c +++ b/src/lib/protocols/tls.c @@ -2052,7 +2052,8 @@ int processClientServerHello(struct ndpi_detection_module_struct *ndpi_struct, for(i=0; ja3.client.alpn[i] != '\0'; i++) if(ja3.client.alpn[i] == ',') ja3.client.alpn[i] = '-'; - } else if(extension_id == 43 /* supported versions */) { + } else if(extension_id == 43 /* supported versions */ && + offset+extension_offset < total_len) { u_int16_t s_offset = offset+extension_offset; u_int8_t version_len = packet->payload[s_offset]; char version_str[256]; |