diff options
| author | Ivan Nardi <12729895+IvanNardi@users.noreply.github.com> | 2021-09-18 09:31:00 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-09-18 09:31:00 +0200 |
| commit | 994bd0696b348adbdd29ede905a53d548c2a2cff (patch) | |
| tree | c6d989823e574771658b1e959a32894159159605 /src/lib/protocols | |
| parent | 227e586e63cb92c6982e1602dbec79891f3910aa (diff) | |
Small fixes after latest commits (#1308)
Diffstat (limited to 'src/lib/protocols')
| -rw-r--r-- | src/lib/protocols/dns.c | 3 | ||||
| -rw-r--r-- | src/lib/protocols/quic.c | 2 |
2 files changed, 3 insertions, 2 deletions
diff --git a/src/lib/protocols/dns.c b/src/lib/protocols/dns.c index 7df539a88..987133213 100644 --- a/src/lib/protocols/dns.c +++ b/src/lib/protocols/dns.c @@ -521,6 +521,7 @@ static void ndpi_search_dns(struct ndpi_detection_module_struct *ndpi_struct, st if((flow->packet.detected_protocol_stack[0] == NDPI_PROTOCOL_DNS) || (flow->packet.detected_protocol_stack[1] == NDPI_PROTOCOL_DNS)) { + /* TODO: add support to RFC6891 to avoid some false positives */ if(flow->packet.udp != NULL && flow->packet.payload_packet_len > PKT_LEN_ALERT) ndpi_set_risk(ndpi_struct, flow, NDPI_DNS_LARGE_PACKET); @@ -529,7 +530,7 @@ static void ndpi_search_dns(struct ndpi_detection_module_struct *ndpi_struct, st u_int8_t flags = ((u_int8_t*)flow->packet.iph)[6]; /* 0: fragmented; 1: not fragmented */ - if((flags & 0xE0) + if((flags & 0x20) || (ndpi_iph_is_valid_and_not_fragmented(flow->packet.iph, flow->packet.l3_packet_len) == 0)) { ndpi_set_risk(ndpi_struct, flow, NDPI_DNS_FRAGMENTED); } diff --git a/src/lib/protocols/quic.c b/src/lib/protocols/quic.c index 9461765c6..7db718ac8 100644 --- a/src/lib/protocols/quic.c +++ b/src/lib/protocols/quic.c @@ -202,7 +202,7 @@ int quic_len(const uint8_t *buf, uint64_t *value) /* Necessary as simple cast crashes on ARM */ memcpy(&n, buf, sizeof(u_int64_t)); - *value = ndpi_ntohll(n & 0x3FFFFFFFFFFFFFFF); + *value = ndpi_ntohll(n) & 0x3FFFFFFFFFFFFFFF; } return 8; default: /* No Possible */ |