diff options
| author | Ivan Nardi <12729895+IvanNardi@users.noreply.github.com> | 2022-09-05 13:59:51 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-09-05 13:59:51 +0200 |
| commit | 0a47f745cc87f967f0d8513b4178321e21a02efc (patch) | |
| tree | bfa7610e8c35281d8c94d35aacd1f67908355721 /src/lib/protocols/tls.c | |
| parent | 01028ee77921cb21dee8b0e5f1f912ffd304244a (diff) | |
Avoid useless host automa lookup (#1724)
The host automa is used for two tasks:
* protocol sub-classification (obviously);
* DGA evaluation: the idea is that if a domain is present in this
automa, it can't be a DGA, regardless of its format/name.
In most dissectors both checks are executed, i.e. the code is something
like:
```
ndpi_match_host_subprotocol(..., flow->host_server_name, ...);
ndpi_check_dga_name(..., flow->host_server_name,...);
```
In that common case, we can perform only one automa lookup: if we check the
sub-classification before the DGA, we can avoid the second lookup in
the DGA function itself.
Diffstat (limited to 'src/lib/protocols/tls.c')
| -rw-r--r-- | src/lib/protocols/tls.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/lib/protocols/tls.c b/src/lib/protocols/tls.c index 98a8d8208..fe36555ed 100644 --- a/src/lib/protocols/tls.c +++ b/src/lib/protocols/tls.c @@ -1923,7 +1923,7 @@ int processClientServerHello(struct ndpi_detection_module_struct *ndpi_struct, } if(ndpi_check_dga_name(ndpi_struct, flow, - sni, 1)) { + sni, 1, 0)) { #ifdef DEBUG_TLS printf("[TLS] SNI: (DGA) [%s]\n", sni); #endif |