diff options
| author | Nardi Ivan <nardi.ivan@gmail.com> | 2022-11-07 18:47:19 +0100 |
|---|---|---|
| committer | Nardi Ivan <nardi.ivan@gmail.com> | 2022-11-07 18:47:19 +0100 |
| commit | aa5dd25392b07d3c1733a3997f5df6494cb01e0f (patch) | |
| tree | f12b7dfba1e591be21783b429d0e1da5e36eb673 /src/lib/protocols/rtp.c | |
| parent | 9e73d61fb0454a143dea6faa4a665c6b7875e195 (diff) | |
RTP: remove a superfluous check
Static analyzer complains about dereferencing `packet->udp` before
checking.
Since this function is called only with UDP flows, remove the check.
Close: #1792
Diffstat (limited to 'src/lib/protocols/rtp.c')
| -rw-r--r-- | src/lib/protocols/rtp.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/src/lib/protocols/rtp.c b/src/lib/protocols/rtp.c index a5fcec4e9..d0ca60a98 100644 --- a/src/lib/protocols/rtp.c +++ b/src/lib/protocols/rtp.c @@ -128,7 +128,7 @@ static void ndpi_rtp_search(struct ndpi_detection_module_struct *ndpi_struct, /* *************************************************************** */ -void ndpi_search_rtp(struct ndpi_detection_module_struct *ndpi_struct, struct ndpi_flow_struct *flow) +static void ndpi_search_rtp(struct ndpi_detection_module_struct *ndpi_struct, struct ndpi_flow_struct *flow) { struct ndpi_packet_struct *packet = &ndpi_struct->packet; u_int16_t source = ntohs(packet->udp->source); @@ -138,8 +138,7 @@ void ndpi_search_rtp(struct ndpi_detection_module_struct *ndpi_struct, struct nd /* printf("*** %s(pkt=%d)\n", __FUNCTION__, flow->packet_counter); */ - if((packet->udp != NULL) - && (source != 30303) && (dest != 30303 /* Avoid to mix it with Ethereum that looks alike */) + if((source != 30303) && (dest != 30303 /* Avoid to mix it with Ethereum that looks alike */) && (dest > 1023) ) ndpi_rtp_search(ndpi_struct, flow, packet->payload, packet->payload_packet_len); |