aboutsummaryrefslogtreecommitdiff
path: root/src/lib/protocols/rsh.c
diff options
context:
space:
mode:
authorLuca Deri <deri@ntop.org>2022-07-04 22:52:54 +0200
committerLuca Deri <deri@ntop.org>2022-07-04 22:52:54 +0200
commit7fa8d882d83577334c7c91843eb40c2ebae8bf74 (patch)
treebb599e4828303ea4c531dec6e224f90247ca8427 /src/lib/protocols/rsh.c
parent461589517e50c201bf063c7d4dbb3639e43f4268 (diff)
Exported username in flow information
Diffstat (limited to 'src/lib/protocols/rsh.c')
-rw-r--r--src/lib/protocols/rsh.c9
1 files changed, 4 insertions, 5 deletions
diff --git a/src/lib/protocols/rsh.c b/src/lib/protocols/rsh.c
index 3344c8660..a3414562c 100644
--- a/src/lib/protocols/rsh.c
+++ b/src/lib/protocols/rsh.c
@@ -88,12 +88,12 @@ void ndpi_search_rsh(struct ndpi_detection_module_struct * ndpi_struct,
}
{
+ char str[64];
char const * dissected_info[] = { (char const *)packet->payload,
NULL, NULL };
size_t i;
- for (i = 1; i < NDPI_ARRAY_LENGTH(dissected_info); ++i)
- {
+ for (i = 1; i < NDPI_ARRAY_LENGTH(dissected_info); ++i) {
dissected_info[i] = memchr(dissected_info[i - 1], '\0',
packet->payload_packet_len -
(dissected_info[i - 1] - dissected_info[0]));
@@ -132,13 +132,12 @@ void ndpi_search_rsh(struct ndpi_detection_module_struct * ndpi_struct,
(unsigned long)packet->payload_packet_len -
(unsigned long)(dissected_info[2] - dissected_info[0])));
- char str[64];
+
if (snprintf(str, NDPI_ARRAY_LENGTH(str), "User '%s' executing '%s'",
flow->protos.rsh.server_username,
flow->protos.rsh.command) < 0)
- {
str[0] = '\0';
- }
+
ndpi_set_risk(ndpi_struct, flow, NDPI_CLEAR_TEXT_CREDENTIALS, str);
}
return;