diff options
| author | Ivan Nardi <12729895+IvanNardi@users.noreply.github.com> | 2025-05-24 13:17:46 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-05-24 13:17:46 +0200 |
| commit | 78f4b60efef27b358b160252b157482d71dbf430 (patch) | |
| tree | 11c43b8e4665b8a9dac1ea4b46f1407f95240149 /src/lib/protocols/hcl_notes.c | |
| parent | c1d372860253e32e6100a3f2c3826f0c50f9116e (diff) | |
A new interface for dissectors registration (#2843)
We use `registr_dissector()` instead of
`ndpi_set_bitmask_protocol_detection()`.
Every file in `src/lib/protocols/*.c` is a dissector.
Every dissector can handle multiple protocols.
The real goal is this small change:
```
struct call_function_struct {
- NDPI_PROTOCOL_BITMASK detection_bitmask;
```
i.e. getting rid of another protocol bitmask: this is mandatory to try
to fix #2136 (see also e845e8205b68752c997d05224d8b2fd45acde714)
As a nice side effect, we remove a bitmask comparison in the hot function
`check_ndpi_detection_func()`
TODO: change logging configuration from per-protocol to per-dissector
Diffstat (limited to 'src/lib/protocols/hcl_notes.c')
| -rw-r--r-- | src/lib/protocols/hcl_notes.c | 12 |
1 files changed, 5 insertions, 7 deletions
diff --git a/src/lib/protocols/hcl_notes.c b/src/lib/protocols/hcl_notes.c index 4f9080360..aa75744e5 100644 --- a/src/lib/protocols/hcl_notes.c +++ b/src/lib/protocols/hcl_notes.c @@ -49,7 +49,7 @@ static void ndpi_check_hcl_notes(struct ndpi_detection_module_struct *ndpi_struc } else if(flow->l4.tcp.hcl_notes_packet_id <= 3) return; - NDPI_EXCLUDE_PROTO(ndpi_struct, flow); + NDPI_EXCLUDE_DISSECTOR(ndpi_struct, flow); } static void ndpi_search_hcl_notes(struct ndpi_detection_module_struct *ndpi_struct, struct ndpi_flow_struct *flow) @@ -62,11 +62,9 @@ static void ndpi_search_hcl_notes(struct ndpi_detection_module_struct *ndpi_stru void init_hcl_notes_dissector(struct ndpi_detection_module_struct *ndpi_struct) { - ndpi_set_bitmask_protocol_detection("HCL_Notes", ndpi_struct, - NDPI_PROTOCOL_HCL_NOTES, - ndpi_search_hcl_notes, - NDPI_SELECTION_BITMASK_PROTOCOL_V4_V6_TCP_WITH_PAYLOAD_WITHOUT_RETRANSMISSION, - SAVE_DETECTION_BITMASK_AS_UNKNOWN, - ADD_TO_DETECTION_BITMASK); + register_dissector("HCL_Notes", ndpi_struct, + ndpi_search_hcl_notes, + NDPI_SELECTION_BITMASK_PROTOCOL_V4_V6_TCP_WITH_PAYLOAD_WITHOUT_RETRANSMISSION, + 1, NDPI_PROTOCOL_HCL_NOTES); } |