aboutsummaryrefslogtreecommitdiff
path: root/src/lib/protocols/gtp.c
diff options
context:
space:
mode:
authorIvan Nardi <12729895+IvanNardi@users.noreply.github.com>2023-05-28 12:59:18 +0200
committerGitHub <noreply@github.com>2023-05-28 12:59:18 +0200
commit7ce14da0c8c06967013503187081fa3a146ab8bb (patch)
tree0bd13c3aa54abf10d3901ef2f9f8d1435b912d88 /src/lib/protocols/gtp.c
parent6da3474203fc2ff5981f6c73f7ad02fa81138166 (diff)
Remove some useless checks (#1993)
In the main dissector callbacks the flow protocols are (almost) always unknown. Only two exceptions: * extra dissection data path * HTTP sub-protocols
Diffstat (limited to 'src/lib/protocols/gtp.c')
-rw-r--r--src/lib/protocols/gtp.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/src/lib/protocols/gtp.c b/src/lib/protocols/gtp.c
index a0c461774..a226d9ebf 100644
--- a/src/lib/protocols/gtp.c
+++ b/src/lib/protocols/gtp.c
@@ -67,7 +67,7 @@ static void ndpi_check_gtp(struct ndpi_detection_module_struct *ndpi_struct, str
struct ndpi_packet_struct *packet = &ndpi_struct->packet;
u_int32_t payload_len = packet->payload_packet_len;
- if((packet->udp != NULL) && (payload_len > sizeof(struct gtp_header_generic))) {
+ if(payload_len > sizeof(struct gtp_header_generic)) {
u_int32_t gtp_u = ntohs(2152);
u_int32_t gtp_c = ntohs(2123);
u_int32_t gtp_prime = ntohs(3386);
@@ -122,9 +122,7 @@ static void ndpi_search_gtp(struct ndpi_detection_module_struct *ndpi_struct, st
{
NDPI_LOG_DBG(ndpi_struct, "search gtp\n");
- /* skip marked packets */
- if(flow->detected_protocol_stack[0] != NDPI_PROTOCOL_GTP)
- ndpi_check_gtp(ndpi_struct, flow);
+ ndpi_check_gtp(ndpi_struct, flow);
}