aboutsummaryrefslogtreecommitdiff
path: root/src/lib/protocols/dropbox.c
diff options
context:
space:
mode:
authorIvan Nardi <12729895+IvanNardi@users.noreply.github.com>2021-10-03 21:38:49 +0200
committerGitHub <noreply@github.com>2021-10-03 21:38:49 +0200
commitbc5be1e76cd8b3d6733f66bffe346486de89b8a0 (patch)
tree385115ff1b786fddb0e0ed3afe6805b0ddb6f51c /src/lib/protocols/dropbox.c
parente84da386c791caf79bbcf9b46357703c946473d9 (diff)
Fix how some protocols handle tcp retransmissions (#1321)
Most (all?) protocols don't care about (tcp) retransmissions. If a protocol registers itself with a NDPI_SELECTION_BITMASK_PROTOCOL_*_WITHOUT_RETRANSMISSION value, its callback is never triggered with a retransmitted packet.
Diffstat (limited to 'src/lib/protocols/dropbox.c')
1 files changed, 1 insertions, 5 deletions
diff --git a/src/lib/protocols/dropbox.c b/src/lib/protocols/dropbox.c
index 39d8c0d22..3683ab131 100644
--- a/src/lib/protocols/dropbox.c
+++ b/src/lib/protocols/dropbox.c
@@ -72,15 +72,11 @@ static void ndpi_check_dropbox(struct ndpi_detection_module_struct *ndpi_struct,
void ndpi_search_dropbox(struct ndpi_detection_module_struct *ndpi_struct, struct ndpi_flow_struct *flow)
{
- struct ndpi_packet_struct *packet = &flow->packet;
-
NDPI_LOG_DBG(ndpi_struct, "search dropbox\n");
/* skip marked packets */
if (flow->detected_protocol_stack[0] != NDPI_PROTOCOL_DROPBOX) {
- if (packet->tcp_retransmission == 0) {
- ndpi_check_dropbox(ndpi_struct, flow);
- }
+ ndpi_check_dropbox(ndpi_struct, flow);
}
}