aboutsummaryrefslogtreecommitdiff
path: root/src/lib/protocols/afp.c
diff options
context:
space:
mode:
authorIvan Nardi <12729895+IvanNardi@users.noreply.github.com>2023-05-09 19:36:02 +0200
committerGitHub <noreply@github.com>2023-05-09 19:36:02 +0200
commit99d7066ea07d21bc282593c09fb6c306c67e09e3 (patch)
tree7460c7122b852e8b2e69ea52e382491d771f2fcd /src/lib/protocols/afp.c
parent684e041998406532c6ef1e899ebc94ca5049d938 (diff)
Remove special handling of some TCP flows without SYN (#1965)
This piece of code has multiple problems: * nDPI is able to detect some TCP protocols even with mid-flows (i.e. without the initial packets of the session); TLS is the most significative example * since e6b332aa4a1399e33df68998cf8351bccaee3fc4 it is perfectly valid to not pass the TCP Handshake packets to nDPI * in any case, we shouldn't call `ndpi_detection_giveup()`. That function is usually called by the application and we end up calling it twice in some cases. The simple solution is to completely remove that code: process these kinds of flows like everyone else. Note that the application can always avoid to pass to nDPI any TCP flows without the initial handshake; the flow managemnt is always up to the application. Looking at the CI results, some rare flows are now processed significantly longer. As a follow-up we could look into that.
Diffstat (limited to 'src/lib/protocols/afp.c')
0 files changed, 0 insertions, 0 deletions