diff options
| author | Ivan Nardi <12729895+IvanNardi@users.noreply.github.com> | 2024-09-23 17:57:17 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-09-23 17:57:17 +0200 |
| commit | efe1930b02544ea5ac2be18297fb93bdebeee1ff (patch) | |
| tree | 566c1acbcf669912fb425adeb4b3920c1216c6a4 /src/lib/ndpi_utils.c | |
| parent | 5c6e8da86cb7166617f45e504bbbf7ee315bbd14 (diff) | |
Fix `ndpi_strrstr()` (#2565)
```
==6591==ERROR: AddressSanitizer: SEGV on unknown address 0x502000230000 (pc 0x55fbd836a5a0 bp 0x7ffdf4503670 sp 0x7ffdf4502e28 T0)
==6591==The signal is caused by a READ memory access.
#0 0x55fbd836a5a0 in __sanitizer::internal_strlen(char const*) /src/llvm-project/compiler-rt/lib/sanitizer_common/sanitizer_libc.cpp:176:10
#1 0x55fbd82cfc28 in StrstrCheck(void*, char*, char const*, char const*) /src/llvm-project/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors.inc:579:17
#2 0x55fbd82cfbc2 in strstr /src/llvm-project/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors.inc:598:5
#3 0x55fbd840a04a in ndpi_strrstr /src/ndpi/src/lib/ndpi_utils.c:3471:15
#4 0x55fbd840ba95 in ndpi_get_host_domain /src/ndpi/src/lib/ndpi_domains.c:149:9
#5 0x55fbd83ef751 in ndpi_check_dga_name /src/ndpi/src/lib/ndpi_main.c:10748:17
```
Found by oss-fuzz
Diffstat (limited to 'src/lib/ndpi_utils.c')
| -rw-r--r-- | src/lib/ndpi_utils.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/lib/ndpi_utils.c b/src/lib/ndpi_utils.c index a1b0a5e6e..6f1034599 100644 --- a/src/lib/ndpi_utils.c +++ b/src/lib/ndpi_utils.c @@ -3470,7 +3470,7 @@ char* ndpi_strrstr(const char *haystack, const char *needle) { while(true) { char *s = strstr(haystack, needle); - if(s == NULL) + if(s == NULL || s[0] == '\0') break; else { ret = s; |