aboutsummaryrefslogtreecommitdiff
path: root/src/include/ndpi_protocols.h
diff options
context:
space:
mode:
authorIvan Nardi <12729895+IvanNardi@users.noreply.github.com>2023-04-25 14:16:27 +0200
committerGitHub <noreply@github.com>2023-04-25 14:16:27 +0200
commitde693cbbc91d4144b8d67a8c99c565ea21cece09 (patch)
tree6ea3f5d77a6514c6877b32b005051bfff642fca6 /src/include/ndpi_protocols.h
parentc4ba981370ff437f27a5da5048e3211beb6c7a5a (diff)
RTP: remove dead-code (#1953)
The checks `isValidMSRTPType(..) == 1` is a subset of `is_valid_rtp_payload_type()` so this if-branch is never reached. More importantly, the article describing how to detect Microsoft Lync and Skype for Business is from 2014. These payload types are static or they are in the dynamic range: in both cases, these values might be used (and they are used indeed) pretty much by every application. Bottom line: we can't use PT alone to identify a specific protocol. Keep the list, since it is used to tell audio streams from video ones.
Diffstat (limited to 'src/include/ndpi_protocols.h')
0 files changed, 0 insertions, 0 deletions