diff options
Diffstat (limited to 'internal/app')
-rw-r--r-- | internal/app/api.go | 36 | ||||
-rw-r--r-- | internal/app/api_test.go | 95 | ||||
-rw-r--r-- | internal/app/metrics.go | 29 |
3 files changed, 160 insertions, 0 deletions
diff --git a/internal/app/api.go b/internal/app/api.go new file mode 100644 index 00000000..c64e946e --- /dev/null +++ b/internal/app/api.go @@ -0,0 +1,36 @@ +// Copyright 2020 The Gogs Authors. All rights reserved. +// Use of this source code is governed by a MIT-style +// license that can be found in the LICENSE file. + +package app + +import ( + "net/http" + + "github.com/microcosm-cc/bluemonday" + "gopkg.in/macaron.v1" + + "gogs.io/gogs/internal/context" +) + +func ipynbSanitizer() *bluemonday.Policy { + p := bluemonday.UGCPolicy() + p.AllowAttrs("class", "data-prompt-number").OnElements("div") + p.AllowAttrs("class").OnElements("img") + p.AllowURLSchemes("data") + return p +} + +func SanitizeIpynb() macaron.Handler { + p := ipynbSanitizer() + + return func(c *context.Context) { + html, err := c.Req.Body().String() + if err != nil { + c.Error(err, "read body") + return + } + + c.PlainText(http.StatusOK, p.Sanitize(html)) + } +} diff --git a/internal/app/api_test.go b/internal/app/api_test.go new file mode 100644 index 00000000..8b123078 --- /dev/null +++ b/internal/app/api_test.go @@ -0,0 +1,95 @@ +// Copyright 2020 The Gogs Authors. All rights reserved. +// Use of this source code is governed by a MIT-style +// license that can be found in the LICENSE file. + +package app + +import ( + "testing" + + "github.com/stretchr/testify/assert" +) + +func Test_ipynbSanitizer(t *testing.T) { + p := ipynbSanitizer() + + tests := []struct { + name string + input string + want string + }{ + { + name: "allow 'class' and 'data-prompt-number' attributes", + input: ` +<div class="nb-notebook"> + <div class="nb-worksheet"> + <div class="nb-cell nb-markdown-cell">Hello world</div> + <div class="nb-cell nb-code-cell"> + <div class="nb-input" data-prompt-number="4"> + </div> + </div> + </div> +</div> +`, + want: ` +<div class="nb-notebook"> + <div class="nb-worksheet"> + <div class="nb-cell nb-markdown-cell">Hello world</div> + <div class="nb-cell nb-code-cell"> + <div class="nb-input" data-prompt-number="4"> + </div> + </div> + </div> +</div> +`, + }, + { + name: "allow base64 encoded images", + input: ` +<div class="nb-output" data-prompt-number="4"> + <img class="nb-image-output" src="data:image/png;base64,iVBORw0KGgoA"/> +</div> +`, + want: ` +<div class="nb-output" data-prompt-number="4"> + <img class="nb-image-output" src="data:image/png;base64,iVBORw0KGgoA"/> +</div> +`, + }, + { + name: "prevent XSS", + input: ` +<div class="nb-output" data-prompt-number="10"> +<div class="nb-html-output"> +<style> +.output { +align-items: center; +background: #00ff00; +} +</style> +<script> +function test() { +alert("test"); +} + +$(document).ready(test); +</script> +</div> +</div> +`, + want: ` +<div class="nb-output" data-prompt-number="10"> +<div class="nb-html-output"> + + +</div> +</div> +`, + }, + } + for _, test := range tests { + t.Run(test.name, func(t *testing.T) { + assert.Equal(t, test.want, p.Sanitize(test.input)) + }) + } +} diff --git a/internal/app/metrics.go b/internal/app/metrics.go new file mode 100644 index 00000000..80ff32f6 --- /dev/null +++ b/internal/app/metrics.go @@ -0,0 +1,29 @@ +// Copyright 2020 The Gogs Authors. All rights reserved. +// Use of this source code is governed by a MIT-style +// license that can be found in the LICENSE file. + +package app + +import ( + "net/http" + + "gopkg.in/macaron.v1" + + "gogs.io/gogs/internal/conf" + "gogs.io/gogs/internal/context" +) + +func MetricsFilter() macaron.Handler { + return func(c *context.Context) { + if !conf.Prometheus.Enabled { + c.Status(http.StatusNotFound) + return + } + + if !conf.Prometheus.EnableBasicAuth { + return + } + + c.RequireBasicAuth(conf.Prometheus.BasicAuthUsername, conf.Prometheus.BasicAuthPassword) + } +} |