diff options
author | Unknwon <u@gogs.io> | 2017-04-04 02:01:29 -0400 |
---|---|---|
committer | Unknwon <u@gogs.io> | 2017-04-04 02:01:29 -0400 |
commit | 41c8e87be8342392092eb74522068dd7452c15cd (patch) | |
tree | 746668185b3b79581bfab6e9bc4d3e743df08a6b /vendor/github.com/gogits | |
parent | 55afc1ad21a6c5bebe7f7f8b6df8b0ee4308ba10 (diff) |
repo/commit: improve error detection
Response 404 not 500 for raw diff if object does not exist.
Diffstat (limited to 'vendor/github.com/gogits')
-rw-r--r-- | vendor/github.com/gogits/git-module/repo_commit.go | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/vendor/github.com/gogits/git-module/repo_commit.go b/vendor/github.com/gogits/git-module/repo_commit.go index 78ff0409..34349c68 100644 --- a/vendor/github.com/gogits/git-module/repo_commit.go +++ b/vendor/github.com/gogits/git-module/repo_commit.go @@ -106,7 +106,7 @@ func (repo *Repository) getCommit(id sha1) (*Commit, error) { data, err := NewCommand("cat-file", "-p", id.String()).RunInDirBytes(repo.Path) if err != nil { - if strings.Contains(err.Error(), "fatal: Not a valid object name") { + if strings.Contains(err.Error(), "exit status 128") { return nil, ErrNotExist{id.String(), ""} } return nil, err @@ -129,6 +129,9 @@ func (repo *Repository) GetCommit(commitID string) (*Commit, error) { var err error commitID, err = NewCommand("rev-parse", commitID).RunInDir(repo.Path) if err != nil { + if strings.Contains(err.Error(), "exit status 128") { + return nil, ErrNotExist{commitID, ""} + } return nil, err } } |