aboutsummaryrefslogtreecommitdiff
path: root/models
diff options
context:
space:
mode:
authorususdei <ususdei@users.noreply.github.com>2018-06-26 14:49:46 +0200
committer无闻 <u@gogs.io>2018-06-26 20:49:46 +0800
commitcd71077c6acb52bf564ede19cf480fddfad72c05 (patch)
tree20f4f65d9eb219c1ed30902d3628d0f3269bafa9 /models
parent029b33c6508b9f320300e68e38184b2eb17ee1d5 (diff)
pull request: able to add custom commit description (#5276)
* pull request merges now allow for custom commit messages * allow i18n on commit_message label * place label above textarea for commit message * rename commit message for pull requests into commit description and pass to git separately
Diffstat (limited to 'models')
-rw-r--r--models/pull.go5
1 files changed, 3 insertions, 2 deletions
diff --git a/models/pull.go b/models/pull.go
index 43211ed7..1d54d082 100644
--- a/models/pull.go
+++ b/models/pull.go
@@ -193,7 +193,7 @@ const (
// Merge merges pull request to base repository.
// FIXME: add repoWorkingPull make sure two merges does not happen at same time.
-func (pr *PullRequest) Merge(doer *User, baseGitRepo *git.Repository, mergeStyle MergeStyle) (err error) {
+func (pr *PullRequest) Merge(doer *User, baseGitRepo *git.Repository, mergeStyle MergeStyle, CommitDescription string) (err error) {
defer func() {
go HookQueue.Add(pr.BaseRepo.ID)
go AddTestPullRequestTask(doer, pr.BaseRepo.ID, pr.BaseBranch, false)
@@ -266,7 +266,8 @@ func (pr *PullRequest) Merge(doer *User, baseGitRepo *git.Repository, mergeStyle
if _, stderr, err = process.ExecDir(-1, tmpBasePath,
fmt.Sprintf("PullRequest.Merge (git merge): %s", tmpBasePath),
"git", "commit", fmt.Sprintf("--author='%s <%s>'", sig.Name, sig.Email),
- "-m", fmt.Sprintf("Merge branch '%s' of %s/%s into %s", pr.HeadBranch, pr.HeadUserName, pr.HeadRepo.Name, pr.BaseBranch)); err != nil {
+ "-m", fmt.Sprintf("Merge branch '%s' of %s/%s into %s", pr.HeadBranch, pr.HeadUserName, pr.HeadRepo.Name, pr.BaseBranch),
+ "-m", CommitDescription); err != nil {
return fmt.Errorf("git commit [%s]: %v - %s", tmpBasePath, err, stderr)
}