autofix: fix check for empty string (#6804)

Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>

13 files changed, 24 insertions, 26 deletions

diff --git a/internal/db/action.go b/internal/db/action.go
index a9efeeb8..970ff203 100644
--- a/internal/db/action.go
+++ b/internal/db/action.go
@@ -325,7 +325,7 @@ func UpdateIssuesCommit(doer *User, repo *Repository, commits []*PushCommit) err
 			ref = strings.TrimSpace(ref)
 			ref = strings.TrimRightFunc(ref, issueIndexTrimRight)
 
-			if len(ref) == 0 {
+			if ref == "" {
 				continue
 			}
 
@@ -368,7 +368,7 @@ func UpdateIssuesCommit(doer *User, repo *Repository, commits []*PushCommit) err
 			ref = ref[strings.IndexByte(ref, byte(' '))+1:]
 			ref = strings.TrimRightFunc(ref, issueIndexTrimRight)
 
-			if len(ref) == 0 {
+			if ref == "" {
 				continue
 			}
 
@@ -407,7 +407,7 @@ func UpdateIssuesCommit(doer *User, repo *Repository, commits []*PushCommit) err
 			ref = ref[strings.IndexByte(ref, byte(' '))+1:]
 			ref = strings.TrimRightFunc(ref, issueIndexTrimRight)
 
-			if len(ref) == 0 {
+			if ref == "" {
 				continue
 			}
 
diff --git a/internal/db/comment.go b/internal/db/comment.go
index 50976357..b5b982bd 100644
--- a/internal/db/comment.go
+++ b/internal/db/comment.go
@@ -364,7 +364,7 @@ func CreateIssueComment(doer *User, repo *Repository, issue *Issue, content stri
 
 // CreateRefComment creates a commit reference comment to issue.
 func CreateRefComment(doer *User, repo *Repository, issue *Issue, content, commitSHA string) error {
-	if len(commitSHA) == 0 {
+	if commitSHA == "" {
 		return fmt.Errorf("cannot create reference with empty commit SHA")
 	}
 
diff --git a/internal/db/issue_label.go b/internal/db/issue_label.go
index 46e8a62c..f7fdf6a6 100644
--- a/internal/db/issue_label.go
+++ b/internal/db/issue_label.go
@@ -33,7 +33,7 @@ func GetLabelTemplateFile(name string) ([][2]string, error) {
 	list := make([][2]string, 0, len(lines))
 	for i := 0; i < len(lines); i++ {
 		line := strings.TrimSpace(lines[i])
-		if len(line) == 0 {
+		if line == "" {
 			continue
 		}
 
diff --git a/internal/db/org.go b/internal/db/org.go
index 88ad0236..cf984f14 100644
--- a/internal/db/org.go
+++ b/internal/db/org.go
@@ -16,9 +16,7 @@ import (
 	"gogs.io/gogs/internal/errutil"
 )
 
-var (
-	ErrOrgNotExist = errors.New("Organization does not exist")
-)
+var ErrOrgNotExist = errors.New("Organization does not exist")
 
 // IsOwnedBy returns true if given user is in the owner team.
 func (org *User) IsOwnedBy(userID int64) bool {
@@ -174,7 +172,7 @@ func CreateOrganization(org, owner *User) (err error) {
 
 // GetOrgByName returns organization by given name.
 func GetOrgByName(name string) (*User, error) {
-	if len(name) == 0 {
+	if name == "" {
 		return nil, ErrOrgNotExist
 	}
 	u := &User{
diff --git a/internal/db/org_team.go b/internal/db/org_team.go
index 216aa0e9..6bdf4253 100644
--- a/internal/db/org_team.go
+++ b/internal/db/org_team.go
@@ -255,7 +255,7 @@ func IsUsableTeamName(name string) error {
 // NewTeam creates a record of new team.
 // It's caller's responsibility to assign organization ID.
 func NewTeam(t *Team) error {
-	if len(t.Name) == 0 {
+	if t.Name == "" {
 		return errors.New("empty team name")
 	} else if t.OrgID == 0 {
 		return errors.New("OrgID is not assigned")
@@ -364,7 +364,7 @@ func GetTeamsByOrgID(orgID int64) ([]*Team, error) {
 
 // UpdateTeam updates information of team.
 func UpdateTeam(t *Team, authChanged bool) (err error) {
-	if len(t.Name) == 0 {
+	if t.Name == "" {
 		return errors.New("empty team name")
 	}
 
diff --git a/internal/db/release.go b/internal/db/release.go
index e38dc8b1..34f65a20 100644
--- a/internal/db/release.go
+++ b/internal/db/release.go
@@ -109,7 +109,7 @@ func (r *Release) APIFormat() *api.Release {
 
 // IsReleaseExist returns true if release with given tag name already exists.
 func IsReleaseExist(repoID int64, tagName string) (bool, error) {
-	if len(tagName) == 0 {
+	if tagName == "" {
 		return false, nil
 	}
 
diff --git a/internal/db/repo.go b/internal/db/repo.go
index c858f2eb..083989a9 100644
--- a/internal/db/repo.go
+++ b/internal/db/repo.go
@@ -217,7 +217,7 @@ func (repo *Repository) AfterSet(colName string, _ xorm.Cell) {
 	switch colName {
 	case "default_branch":
 		// FIXME: use db migration to solve all at once.
-		if len(repo.DefaultBranch) == 0 {
+		if repo.DefaultBranch == "" {
 			repo.DefaultBranch = "master"
 		}
 	case "num_closed_issues":
@@ -227,7 +227,7 @@ func (repo *Repository) AfterSet(colName string, _ xorm.Cell) {
 	case "num_closed_milestones":
 		repo.NumOpenMilestones = repo.NumMilestones - repo.NumClosedMilestones
 	case "external_tracker_style":
-		if len(repo.ExternalTrackerStyle) == 0 {
+		if repo.ExternalTrackerStyle == "" {
 			repo.ExternalTrackerStyle = markup.IssueNameStyleNumeric
 		}
 	case "created_unix":
diff --git a/internal/db/ssh_key.go b/internal/db/ssh_key.go
index 2f783a9f..f1fc04aa 100644
--- a/internal/db/ssh_key.go
+++ b/internal/db/ssh_key.go
@@ -147,7 +147,7 @@ func parseKeyString(content string) (string, error) {
 		if err != nil {
 			return "", fmt.Errorf("extractTypeFromBase64Key: %v", err)
 		}
-		if len(keyType) == 0 {
+		if keyType == "" {
 			keyType = t
 		} else if keyType != t {
 			return "", fmt.Errorf("key type and content does not match: %s - %s", keyType, t)
diff --git a/internal/db/user.go b/internal/db/user.go
index 3ebaabff..d5d2d60f 100644
--- a/internal/db/user.go
+++ b/internal/db/user.go
@@ -222,7 +222,7 @@ func (u *User) CustomAvatarPath() string {
 // GenerateRandomAvatar generates a random avatar for user.
 func (u *User) GenerateRandomAvatar() error {
 	seed := u.Email
-	if len(seed) == 0 {
+	if seed == "" {
 		seed = u.Name
 	}
 
@@ -479,7 +479,7 @@ func (u *User) IsMailable() bool {
 // If uid is presented, then check will rule out that one,
 // it is used when update a user name in settings page.
 func IsUserExist(uid int64, name string) (bool, error) {
-	if len(name) == 0 {
+	if name == "" {
 		return false, nil
 	}
 	return x.Where("id != ?", uid).Get(&User{LowerName: strings.ToLower(name)})
@@ -729,7 +729,7 @@ func updateUser(e Engine, u *User) error {
 			return ErrEmailAlreadyUsed{args: errutil.Args{"email": u.Email}}
 		}
 
-		if len(u.AvatarEmail) == 0 {
+		if u.AvatarEmail == "" {
 			u.AvatarEmail = u.Email
 		}
 		u.Avatar = tool.HashEmail(u.AvatarEmail)
@@ -955,7 +955,7 @@ func GetAssigneeByID(repo *Repository, userID int64) (*User, error) {
 // GetUserByName returns a user by given name.
 // Deprecated: Use Users.GetByUsername instead.
 func GetUserByName(name string) (*User, error) {
-	if len(name) == 0 {
+	if name == "" {
 		return nil, ErrUserNotExist{args: map[string]interface{}{"name": name}}
 	}
 	u := &User{LowerName: strings.ToLower(name)}
@@ -1035,7 +1035,7 @@ func ValidateCommitsWithEmails(oldCommits []*git.Commit) []*UserCommit {
 // GetUserByEmail returns the user object by given e-mail if exists.
 // Deprecated: Use Users.GetByEmail instead.
 func GetUserByEmail(email string) (*User, error) {
-	if len(email) == 0 {
+	if email == "" {
 		return nil, ErrUserNotExist{args: map[string]interface{}{"email": email}}
 	}
 
@@ -1074,7 +1074,7 @@ type SearchUserOptions struct {
 // SearchUserByName takes keyword and part of user name to search,
 // it returns results in given range and number of total results.
 func SearchUserByName(opts *SearchUserOptions) (users []*User, _ int64, _ error) {
-	if len(opts.Keyword) == 0 {
+	if opts.Keyword == "" {
 		return users, 0, nil
 	}
 	opts.Keyword = strings.ToLower(opts.Keyword)
diff --git a/internal/db/user_mail.go b/internal/db/user_mail.go
index 990b4aa1..fc6e1618 100644
--- a/internal/db/user_mail.go
+++ b/internal/db/user_mail.go
@@ -57,7 +57,7 @@ func GetEmailAddresses(uid int64) ([]*EmailAddress, error) {
 }
 
 func isEmailUsed(e Engine, email string) (bool, error) {
-	if len(email) == 0 {
+	if email == "" {
 		return true, nil
 	}
 
diff --git a/internal/db/users.go b/internal/db/users.go
index ebf2af87..096a2702 100644
--- a/internal/db/users.go
+++ b/internal/db/users.go
@@ -278,7 +278,7 @@ func (ErrUserNotExist) NotFound() bool {
 func (db *users) GetByEmail(email string) (*User, error) {
 	email = strings.ToLower(email)
 
-	if len(email) == 0 {
+	if email == "" {
 		return nil, ErrUserNotExist{args: errutil.Args{"email": email}}
 	}
 
diff --git a/internal/db/webhook.go b/internal/db/webhook.go
index 457fa6cb..bca1fb91 100644
--- a/internal/db/webhook.go
+++ b/internal/db/webhook.go
@@ -470,7 +470,7 @@ func (t *HookTask) AfterSet(colName string, _ xorm.Cell) {
 		t.DeliveredString = time.Unix(0, t.Delivered).Format("2006-01-02 15:04:05 MST")
 
 	case "request_content":
-		if len(t.RequestContent) == 0 {
+		if t.RequestContent == "" {
 			return
 		}
 
@@ -480,7 +480,7 @@ func (t *HookTask) AfterSet(colName string, _ xorm.Cell) {
 		}
 
 	case "response_content":
-		if len(t.ResponseContent) == 0 {
+		if t.ResponseContent == "" {
 			return
 		}
 
diff --git a/internal/db/wiki.go b/internal/db/wiki.go
index 5fbb9fb6..f2276b61 100644
--- a/internal/db/wiki.go
+++ b/internal/db/wiki.go
@@ -122,7 +122,7 @@ func (repo *Repository) updateWikiPage(doer *User, oldTitle, title, content, mes
 		return fmt.Errorf("WriteFile: %v", err)
 	}
 
-	if len(message) == 0 {
+	if message == "" {
 		message = "Update page '" + title + "'"
 	}
 	if err = git.RepoAdd(localPath, git.AddOptions{All: true}); err != nil {