diff options
| author | Toni Uhlig <matzeton@googlemail.com> | 2018-07-18 15:30:23 +0200 |
|---|---|---|
| committer | Toni Uhlig <matzeton@googlemail.com> | 2018-07-18 15:30:23 +0200 |
| commit | e352835e2df91e5496846cf35310f06ff64024f4 (patch) | |
| tree | 5e7549192be5cdd5de801d19e1c646a8f77f1df9 /src | |
| parent | b30adf7145a949f181d57097fc986a4f9f5a1c17 (diff) | |
Coverity CID 301785: check return value of remove() although it is not necessary
Signed-off-by: Toni Uhlig <matzeton@googlemail.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/protocol_ssh.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/src/protocol_ssh.c b/src/protocol_ssh.c index e40661a..ec2664c 100644 --- a/src/protocol_ssh.c +++ b/src/protocol_ssh.c @@ -320,8 +320,8 @@ static int gen_default_keys(void) rsa_key_suf); if (gen_export_sshkey(SSH_KEYTYPE_RSA, 1024, path)) { W("libssh %s key generation failed, using fallback ssh-keygen", "RSA"); - remove(path); - if (snprintf(cmd, sizeof cmd, "ssh-keygen -t rsa -b 1024 -f %s -N '' " + if ((!remove(path) || errno == ENOENT) && + snprintf(cmd, sizeof cmd, "ssh-keygen -t rsa -b 1024 -f %s -N '' " ">/dev/null 2>/dev/null", path) > 0) { s |= system(cmd); @@ -336,8 +336,8 @@ static int gen_default_keys(void) dsa_key_suf); if (gen_export_sshkey(SSH_KEYTYPE_DSS, 1024, path)) { W("libssh %s key generation failed, using fallback ssh-keygen", "DSA"); - remove(path); - if (snprintf(cmd, sizeof cmd, "ssh-keygen -t dsa -b 1024 -f %s -N '' " + if ((!remove(path) || errno == ENOENT) && + snprintf(cmd, sizeof cmd, "ssh-keygen -t dsa -b 1024 -f %s -N '' " ">/dev/null 2>/dev/null", path) > 0) { s |= system(cmd); @@ -352,8 +352,8 @@ static int gen_default_keys(void) ecdsa_key_suf); if (gen_export_sshkey(SSH_KEYTYPE_ECDSA, 1024, path)) { W("libssh %s key generation failed, using fallback ssh-keygen", "ECDSA"); - remove(path); - if (snprintf(cmd, sizeof cmd, "ssh-keygen -t ecdsa -b 256 -f %s -N '' " + if ((!remove(path) || errno == ENOENT) && + snprintf(cmd, sizeof cmd, "ssh-keygen -t ecdsa -b 256 -f %s -N '' " ">/dev/null 2>/dev/null", path) > 0) { s |= system(cmd); |