From 30ea917518b4d0643e0e2aa21daa26f78290bbbf Mon Sep 17 00:00:00 2001 From: Paul Spooren Date: Sun, 9 Aug 2020 13:19:25 -1000 Subject: treewide: replace `which` with `command -v` Fix shellcheck SC2230 > which is non-standard. Use builtin 'command -v' instead. Once applied to everything concerning OpenWrt we can disable the busybox feature `which` and save 3.8kB. Signed-off-by: Paul Spooren --- net/mwan3/files/usr/sbin/mwan3track | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'net/mwan3/files') diff --git a/net/mwan3/files/usr/sbin/mwan3track b/net/mwan3/files/usr/sbin/mwan3track index e112475ce..a4ced8255 100755 --- a/net/mwan3/files/usr/sbin/mwan3track +++ b/net/mwan3/files/usr/sbin/mwan3track @@ -23,19 +23,19 @@ if_down() { validate_track_method() { case "$1" in ping) - which ping 1>/dev/null 2>&1 || { + command -v ping 1>/dev/null 2>&1 || { $LOG warn "Missing ping. Please install iputils-ping package or enable ping util and recompile busybox." return 1 } ;; arping) - which arping 1>/dev/null 2>&1 || { + command -v arping 1>/dev/null 2>&1 || { $LOG warn "Missing arping. Please install iputils-arping package." return 1 } ;; httping) - which httping 1>/dev/null 2>&1 || { + command -v httping 1>/dev/null 2>&1 || { $LOG warn "Missing httping. Please install httping package." return 1 } @@ -45,7 +45,7 @@ validate_track_method() { } ;; nping-*) - which nping 1>/dev/null 2>&1 || { + command -v nping 1>/dev/null 2>&1 || { $LOG warn "Missing nping. Please install nping package." return 1 } -- cgit v1.2.3