From dfd044930689aa6d2af94d15d1372923c5302ffb Mon Sep 17 00:00:00 2001 From: Toni Uhlig Date: Thu, 5 Oct 2023 12:33:13 +0200 Subject: Fix issues detected by SonarCloud. Signed-off-by: Toni Uhlig --- examples/c-captured/c-captured.c | 5 ++++- examples/c-collectd/c-collectd.c | 5 ++--- examples/c-json-stdout/c-json-stdout.c | 2 +- 3 files changed, 7 insertions(+), 5 deletions(-) (limited to 'examples') diff --git a/examples/c-captured/c-captured.c b/examples/c-captured/c-captured.c index 8eac71ab3..e810f3e70 100644 --- a/examples/c-captured/c-captured.c +++ b/examples/c-captured/c-captured.c @@ -1354,7 +1354,10 @@ int main(int argc, char ** argv) } return 1; } - chmod(datadir, S_IRWXU); + if (datadir != NULL) + { + chmod(datadir, S_IRWXU); + } if (nDPIsrvd_set_read_timeout(sock, 180, 0) != 0) { diff --git a/examples/c-collectd/c-collectd.c b/examples/c-collectd/c-collectd.c index 30e8da553..3f8e2aef0 100644 --- a/examples/c-collectd/c-collectd.c +++ b/examples/c-collectd/c-collectd.c @@ -726,7 +726,7 @@ static enum nDPIsrvd_callback_return collectd_json_callback(struct nDPIsrvd_sock struct nDPIsrvd_json_token const * current = NULL; int next_child_index = -1; - if (flow_risk != NULL) + if (flow_risk != NULL && flow_user_data != NULL) { if (flow_user_data->detected_risks == 0) { @@ -744,13 +744,12 @@ static enum nDPIsrvd_callback_return collectd_json_callback(struct nDPIsrvd_sock if (numeric_risk_value < NDPI_MAX_RISK && numeric_risk_value > 0) { collectd_statistics.flow_risk_count[numeric_risk_value - 1]++; + flow_user_data->detected_risks |= (1ull << (numeric_risk_value - 1)); } else { collectd_statistics.flow_risk_unknown_count++; } - - flow_user_data->detected_risks |= (1ull << (numeric_risk_value - 1)); } } } diff --git a/examples/c-json-stdout/c-json-stdout.c b/examples/c-json-stdout/c-json-stdout.c index 508e45588..ae082a366 100644 --- a/examples/c-json-stdout/c-json-stdout.c +++ b/examples/c-json-stdout/c-json-stdout.c @@ -104,7 +104,7 @@ int main(void) json_bytes - json_start, tokens, sizeof(tokens) / sizeof(tokens[0])); - if (r < 0 || tokens[0].type != JSMN_OBJECT) + if (r < 1 || tokens[0].type != JSMN_OBJECT) { fprintf(stderr, "JSON parsing failed with return value %d at position %u\n", r, parser.pos); fprintf(stderr, "JSON string: '%.*s'\n", (int)(json_bytes - json_start), (char *)(buf + json_start)); -- cgit v1.2.3