From 97b80a8838a5187163eef3a54a711a8c0cee8742 Mon Sep 17 00:00:00 2001 From: Nardi Ivan Date: Mon, 24 Aug 2020 13:53:36 +0200 Subject: QUIC: minor fixes LGTM found a real issue on a boundary check Fix unit tests: a pcap ha been uploaded twice (with different names) Fix compilation when using DPDK (see #990) --- tests/pcap/ietf_quic.pcap | Bin 11356 -> 0 bytes tests/pcap/quic-28.pcap | Bin 0 -> 250865 bytes tests/pcap/quic-28.pcapng | Bin 256428 -> 0 bytes tests/pcap/quic-29.pcap | Bin 0 -> 9650 bytes tests/pcap/quic-29.pcapng | Bin 11356 -> 0 bytes tests/result/ietf_quic.pcap.out | 8 -------- tests/result/quic-28.pcap.out | 8 ++++++++ tests/result/quic-29.pcap.out | 8 ++++++++ 8 files changed, 16 insertions(+), 8 deletions(-) delete mode 100644 tests/pcap/ietf_quic.pcap create mode 100644 tests/pcap/quic-28.pcap delete mode 100644 tests/pcap/quic-28.pcapng create mode 100644 tests/pcap/quic-29.pcap delete mode 100644 tests/pcap/quic-29.pcapng delete mode 100644 tests/result/ietf_quic.pcap.out create mode 100644 tests/result/quic-28.pcap.out create mode 100644 tests/result/quic-29.pcap.out (limited to 'tests') diff --git a/tests/pcap/ietf_quic.pcap b/tests/pcap/ietf_quic.pcap deleted file mode 100644 index c0034b2c9..000000000 Binary files a/tests/pcap/ietf_quic.pcap and /dev/null differ diff --git a/tests/pcap/quic-28.pcap b/tests/pcap/quic-28.pcap new file mode 100644 index 000000000..e93354cea Binary files /dev/null and b/tests/pcap/quic-28.pcap differ diff --git a/tests/pcap/quic-28.pcapng b/tests/pcap/quic-28.pcapng deleted file mode 100644 index 733d665d7..000000000 Binary files a/tests/pcap/quic-28.pcapng and /dev/null differ diff --git a/tests/pcap/quic-29.pcap b/tests/pcap/quic-29.pcap new file mode 100644 index 000000000..4694660cd Binary files /dev/null and b/tests/pcap/quic-29.pcap differ diff --git a/tests/pcap/quic-29.pcapng b/tests/pcap/quic-29.pcapng deleted file mode 100644 index c0034b2c9..000000000 Binary files a/tests/pcap/quic-29.pcapng and /dev/null differ diff --git a/tests/result/ietf_quic.pcap.out b/tests/result/ietf_quic.pcap.out deleted file mode 100644 index 5a1997a7c..000000000 --- a/tests/result/ietf_quic.pcap.out +++ /dev/null @@ -1,8 +0,0 @@ -QUIC 15 9386 1 - -JA3 Host Stats: - IP Address # JA3C - 1 10.9.0.1 1 - - - 1 UDP 10.9.0.1:36588 <-> 10.9.0.2:443 [proto: 188/QUIC][cat: Web/5][6 pkts/4555 bytes <-> 9 pkts/4831 bytes][Goodput ratio: 94/92][0.04 sec][ALPN: h3-29][TLS Supported Versions: TLSv1.3][bytes ratio: -0.029 (Mixed)][IAT c2s/s2c min/avg/max/stddev: 1/0 6/3 18/8 7/3][Pkt Len c2s/s2c min/avg/max/stddev: 84/81 759/537 1294/1294 552/493][TLSv1.3][Client: localhost][JA3C: b3e43d74f4b790abca2f5fe7dd06e7cf][PLAIN TEXT (SYmlKmO)][Plen Bins: 0,27,0,13,0,0,0,0,6,0,6,0,0,0,6,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,6,0,0,0,0,0,0,0,34,0,0,0,0,0,0,0,0] diff --git a/tests/result/quic-28.pcap.out b/tests/result/quic-28.pcap.out new file mode 100644 index 000000000..7cf2e4ac3 --- /dev/null +++ b/tests/result/quic-28.pcap.out @@ -0,0 +1,8 @@ +Cloudflare 253 246793 1 + +JA3 Host Stats: + IP Address # JA3C + 1 10.9.0.2 1 + + + 1 UDP 10.9.0.2:60106 <-> 104.26.11.240:443 [proto: 188.220/QUIC.Cloudflare][cat: Web/5][34 pkts/6856 bytes <-> 219 pkts/239937 bytes][Goodput ratio: 79/96][2.76 sec][ALPN: h3-28;h3-27][TLS Supported Versions: TLSv1.3][bytes ratio: -0.944 (Download)][IAT c2s/s2c min/avg/max/stddev: 0/0 77/14 1007/1023 229/91][Pkt Len c2s/s2c min/avg/max/stddev: 85/84 202/1096 1242/1242 325/364][TLSv1.3][Client: www.wireshark.org][JA3C: 1e022f87823477abd6a79c31d70062d7][PLAIN TEXT (tGLddu)][Plen Bins: 0,16,2,1,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,80,0,0,0,0,0,0,0,0,0,0] diff --git a/tests/result/quic-29.pcap.out b/tests/result/quic-29.pcap.out new file mode 100644 index 000000000..5a1997a7c --- /dev/null +++ b/tests/result/quic-29.pcap.out @@ -0,0 +1,8 @@ +QUIC 15 9386 1 + +JA3 Host Stats: + IP Address # JA3C + 1 10.9.0.1 1 + + + 1 UDP 10.9.0.1:36588 <-> 10.9.0.2:443 [proto: 188/QUIC][cat: Web/5][6 pkts/4555 bytes <-> 9 pkts/4831 bytes][Goodput ratio: 94/92][0.04 sec][ALPN: h3-29][TLS Supported Versions: TLSv1.3][bytes ratio: -0.029 (Mixed)][IAT c2s/s2c min/avg/max/stddev: 1/0 6/3 18/8 7/3][Pkt Len c2s/s2c min/avg/max/stddev: 84/81 759/537 1294/1294 552/493][TLSv1.3][Client: localhost][JA3C: b3e43d74f4b790abca2f5fe7dd06e7cf][PLAIN TEXT (SYmlKmO)][Plen Bins: 0,27,0,13,0,0,0,0,6,0,6,0,0,0,6,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,6,0,0,0,0,0,0,0,34,0,0,0,0,0,0,0,0] -- cgit v1.2.3