From 172e698bb8239d0060d9d494adfba928507f95b2 Mon Sep 17 00:00:00 2001 From: Ivan Nardi <12729895+IvanNardi@users.noreply.github.com> Date: Thu, 28 Jul 2022 12:39:18 +0200 Subject: TINC: avoid processing SYN packets (#1676) Since e6b332aa, we have proper support for detecting client/server direction. So Tinc dissector is now able to properly initialize the cache entry only when needed and not anymore at the SYN time; initializing that entry for **every** SYN packets was a complete waste of resources. Since 4896dabb, the various `struct ndpi_call_function_struct` structures are not more separate objects and therefore comparing them using only their pointers is bogus: this bug was triggered by this change because `ndpi_str->callback_buffer_size_tcp_no_payload` is now 0. --- tests/result/simple-dnscrypt.pcap.out | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'tests/result/simple-dnscrypt.pcap.out') diff --git a/tests/result/simple-dnscrypt.pcap.out b/tests/result/simple-dnscrypt.pcap.out index e46141f8b..c803ee7f2 100644 --- a/tests/result/simple-dnscrypt.pcap.out +++ b/tests/result/simple-dnscrypt.pcap.out @@ -3,7 +3,7 @@ Guessed flow protos: 0 DPI Packets (TCP): 47 (11.75 pkts/flow) Confidence DPI (cache) : 3 (flows) Confidence DPI : 1 (flows) -Num dissector calls: 16 (4.00 diss/flow) +Num dissector calls: 4 (1.00 diss/flow) DNScrypt 111 44676 4 -- cgit v1.2.3