From 933351840dbed3646aeb4f75a359649434b001eb Mon Sep 17 00:00:00 2001 From: Philippe Antoine Date: Wed, 26 Feb 2020 16:59:04 +0100 Subject: Fix off by one in imap --- src/lib/protocols/mail_imap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src') diff --git a/src/lib/protocols/mail_imap.c b/src/lib/protocols/mail_imap.c index 99b386205..c3a18c065 100644 --- a/src/lib/protocols/mail_imap.c +++ b/src/lib/protocols/mail_imap.c @@ -161,7 +161,7 @@ void ndpi_search_mail_imap_tcp(struct ndpi_detection_module_struct *ndpi_struct, && (packet->payload[command_start + 4] == 'N' || packet->payload[command_start + 4] == 'n')) { /* xxxx LOGIN "username" "password" */ char str[256], *item; - u_int len = packet->payload_packet_len > sizeof(str) ? sizeof(str) : packet->payload_packet_len; + u_int len = packet->payload_packet_len >= sizeof(str) ? sizeof(str)-1 : packet->payload_packet_len; strncpy(str, (const char*)packet->payload, len); str[len] = '\0'; -- cgit v1.2.3