From 58f0f2911372ccd316c51fb81429cfeaa3b4f470 Mon Sep 17 00:00:00 2001 From: Nardi Ivan Date: Thu, 26 Mar 2020 17:27:41 +0100 Subject: soulseek: fix heap-overflow error --- src/lib/protocols/soulseek.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src') diff --git a/src/lib/protocols/soulseek.c b/src/lib/protocols/soulseek.c index a08774bb8..042ead2b8 100644 --- a/src/lib/protocols/soulseek.c +++ b/src/lib/protocols/soulseek.c @@ -196,7 +196,7 @@ void ndpi_search_soulseek_tcp(struct ndpi_detection_module_struct *ndpi_struct, && !get_u_int16_t(packet->payload, 2)) { const u_int32_t usrlen = get_l32(packet->payload, 5); - if(usrlen <= packet->payload_packet_len - 4 + 1 + 4 + 4 + 1 + 4) { + if(usrlen <= packet->payload_packet_len - (4 + 1 + 4 + 4 + 1 + 4)) { const u_int32_t typelen = get_l32(packet->payload, 4 + 1 + 4 + usrlen); const u_int8_t type = packet->payload[4 + 1 + 4 + usrlen + 4]; if(typelen == 1 && (type == 'F' || type == 'P' || type == 'D')) { -- cgit v1.2.3