From 15f0e1480c4324afa0350fa7f1d839d2dc4fc1fa Mon Sep 17 00:00:00 2001 From: Ivan Kapranov <44571881+koltiradw@users.noreply.github.com> Date: Thu, 22 Jun 2023 22:36:40 +0300 Subject: minor fixes (#2023) fixed 'handle leak' in ndpi_load_malicious_sha1_file and removed the redundant comparison ndpi_search_eaq Co-authored-by: Ivan Kapranov --- src/lib/ndpi_main.c | 2 ++ src/lib/protocols/eaq.c | 3 +-- 2 files changed, 3 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/lib/ndpi_main.c b/src/lib/ndpi_main.c index 7f88d8b1c..6a49c22c0 100644 --- a/src/lib/ndpi_main.c +++ b/src/lib/ndpi_main.c @@ -4258,6 +4258,8 @@ int ndpi_load_malicious_sha1_file(struct ndpi_detection_module_struct *ndpi_str, num++; } + fclose(fd); + return num; } diff --git a/src/lib/protocols/eaq.c b/src/lib/protocols/eaq.c index d01cae9d3..ff97641ec 100644 --- a/src/lib/protocols/eaq.c +++ b/src/lib/protocols/eaq.c @@ -51,7 +51,6 @@ static void ndpi_search_eaq(struct ndpi_detection_module_struct *ndpi_struct, st ((sport != EAQ_DEFAULT_PORT) && (dport != EAQ_DEFAULT_PORT)) ) break; - if(packet->udp != NULL) { u_int32_t seq = (packet->payload[0] * 1000) + (packet->payload[1] * 100) + (packet->payload[2] * 10) + packet->payload[3]; if(flow->l4.udp.eaq_pkt_id == 0) @@ -71,7 +70,7 @@ static void ndpi_search_eaq(struct ndpi_detection_module_struct *ndpi_struct, st return; } else return; - } + } while(0); NDPI_EXCLUDE_PROTO(ndpi_struct, flow); -- cgit v1.2.3