From 8074bc82013c9b14cc59a32fcc7c75a6b56ff8dd Mon Sep 17 00:00:00 2001
From: Ivan Nardi <12729895+IvanNardi@users.noreply.github.com>
Date: Tue, 9 Mar 2021 19:46:32 +0100
Subject: HTTP: fix memory access in ndpi_http_parse_subprotocol() (#1151)

---
 src/lib/protocols/http.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

(limited to 'src/lib')

diff --git a/src/lib/protocols/http.c b/src/lib/protocols/http.c
index 443fc80f8..9cbd1df5c 100644
--- a/src/lib/protocols/http.c
+++ b/src/lib/protocols/http.c
@@ -352,8 +352,9 @@ static void ndpi_http_parse_subprotocol(struct ndpi_detection_module_struct *ndp
     if(ndpi_match_hostname_protocol(ndpi_struct, flow, NDPI_PROTOCOL_HTTP,
 				    (char *)flow->host_server_name,
 				    strlen((const char *)flow->host_server_name)) == 0) {
-      if((strstr(flow->http.url, ":8080/downloading?n=0.") != NULL)
-	 || (strstr(flow->http.url, ":8080/upload?n=0.") != NULL)) {
+      if(flow->http.url &&
+         ((strstr(flow->http.url, ":8080/downloading?n=0.") != NULL)
+          || (strstr(flow->http.url, ":8080/upload?n=0.") != NULL))) {
 	/* This looks like Ookla speedtest */
 	ndpi_set_detected_protocol(ndpi_struct, flow, NDPI_PROTOCOL_OOKLA, NDPI_PROTOCOL_HTTP);
       }
-- 
cgit v1.2.3