From ced6fca184a4549333c2d582e53419f66cd99ec1 Mon Sep 17 00:00:00 2001 From: Toni Date: Tue, 29 Jun 2021 15:33:12 +0200 Subject: Fixed off-by-one memory error for TLS-JA3. (#1222) Signed-off-by: Toni Uhlig --- src/lib/protocols/tls.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'src/lib/protocols') diff --git a/src/lib/protocols/tls.c b/src/lib/protocols/tls.c index 4f376a4ff..ed3caed5f 100644 --- a/src/lib/protocols/tls.c +++ b/src/lib/protocols/tls.c @@ -1849,7 +1849,11 @@ int processClientServerHello(struct ndpi_detection_module_struct *ndpi_struct, duplicate_found); #endif - ja3.client.signature_algorithms[i*2] = '\0'; + if (i == tot_signature_algorithms_len) { + ja3.client.signature_algorithms[i*2 - 1] = '\0'; + } else { + ja3.client.signature_algorithms[i*2] = '\0'; + } #ifdef DEBUG_TLS printf("Client TLS [SIGNATURE_ALGORITHMS: %s]\n", ja3.client.signature_algorithms); -- cgit v1.2.3