From 7ce14da0c8c06967013503187081fa3a146ab8bb Mon Sep 17 00:00:00 2001
From: Ivan Nardi <12729895+IvanNardi@users.noreply.github.com>
Date: Sun, 28 May 2023 12:59:18 +0200
Subject: Remove some useless checks (#1993)

In the main dissector callbacks the flow protocols are (almost) always
unknown. Only two exceptions:
* extra dissection data path
* HTTP sub-protocols
---
 src/lib/protocols/vhua.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

(limited to 'src/lib/protocols/vhua.c')

diff --git a/src/lib/protocols/vhua.c b/src/lib/protocols/vhua.c
index 6b0e29276..e37bbb021 100644
--- a/src/lib/protocols/vhua.c
+++ b/src/lib/protocols/vhua.c
@@ -43,7 +43,6 @@ static void ndpi_check_vhua(struct ndpi_detection_module_struct *ndpi_struct, st
 
   /* Break after 3 packets. */
   if((flow->packet_counter > 3)
-     || (packet->udp == NULL)
      || (packet->payload_packet_len < sizeof(p0))) {
     NDPI_EXCLUDE_PROTO(ndpi_struct, flow);
   } else if(memcmp(packet->payload, p0, sizeof(p0)) == 0) {
@@ -54,10 +53,7 @@ static void ndpi_check_vhua(struct ndpi_detection_module_struct *ndpi_struct, st
 static void ndpi_search_vhua(struct ndpi_detection_module_struct *ndpi_struct, struct ndpi_flow_struct *flow) {
   NDPI_LOG_DBG(ndpi_struct, "search VHUA\n");
 
-  /* skip marked packets */
-  if(flow->detected_protocol_stack[0] != NDPI_PROTOCOL_VHUA) {
-    ndpi_check_vhua(ndpi_struct, flow);
-  }
+  ndpi_check_vhua(ndpi_struct, flow);
 }
 
 
-- 
cgit v1.2.3