From 7263562514ac8c98ca923b98cc89d4c10bbdb30f Mon Sep 17 00:00:00 2001 From: Thomas Winter Date: Mon, 21 Aug 2023 11:04:20 +1200 Subject: tftp: check for Option Acknowledgements TFTP Option Acknowledgement packets were being excluded. When a read/write request contains options, an Option Acknowledgement is returned that contains the option strings that the transaction will use. The options sent in the request are not compared with what was acknowledged. --- src/lib/protocols/tftp.c | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'src/lib/protocols/tftp.c') diff --git a/src/lib/protocols/tftp.c b/src/lib/protocols/tftp.c index 135d1bea2..4b505c8fd 100644 --- a/src/lib/protocols/tftp.c +++ b/src/lib/protocols/tftp.c @@ -165,6 +165,11 @@ static void ndpi_search_tftp(struct ndpi_detection_module_struct *ndpi_struct, } break; + case 0x06: + /* Option Acknowledgment (OACK) */ + /* No fixed lengths as it can include the options from the request. */ + break; + default: NDPI_EXCLUDE_PROTO(ndpi_struct, flow); return; -- cgit v1.2.3