From 29c5cc39fb7f714897c3d6a3454e696e263fb9bc Mon Sep 17 00:00:00 2001 From: Ivan Nardi <12729895+IvanNardi@users.noreply.github.com> Date: Wed, 25 Jan 2023 11:44:09 +0100 Subject: Some small changes (#1869) All dissector callbacks should not be exported by the library; make static some other local functions. The callback logic in `ndpiReader` has never been used. With internal libgcrypt, `gcry_control()` should always return no errors. We can check `categories` length at compilation time. --- src/lib/protocols/starcraft.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'src/lib/protocols/starcraft.c') diff --git a/src/lib/protocols/starcraft.c b/src/lib/protocols/starcraft.c index d7368c4ca..b947e433e 100644 --- a/src/lib/protocols/starcraft.c +++ b/src/lib/protocols/starcraft.c @@ -27,7 +27,7 @@ /* Sender or receiver are one of the known login portals? */ -u_int8_t sc2_match_logon_ip(struct ndpi_packet_struct* packet) +static u_int8_t sc2_match_logon_ip(struct ndpi_packet_struct* packet) { if (packet->iph == NULL) return 0; @@ -47,7 +47,7 @@ u_int8_t sc2_match_logon_ip(struct ndpi_packet_struct* packet) transfer generated by the user interaction with the client, e.g. chatting or looking at someone's match history. The current way to detect this is plain dumb packet matching. */ -u_int8_t ndpi_check_starcraft_tcp(struct ndpi_detection_module_struct* ndpi_struct, struct ndpi_flow_struct* flow) +static u_int8_t ndpi_check_starcraft_tcp(struct ndpi_detection_module_struct* ndpi_struct, struct ndpi_flow_struct* flow) { struct ndpi_packet_struct* packet = &ndpi_struct->packet; @@ -66,7 +66,7 @@ u_int8_t ndpi_check_starcraft_tcp(struct ndpi_detection_module_struct* ndpi_stru some other Blizzard software. The flow is taken if a pattern in the size of some subsequent packets is found. */ -u_int8_t ndpi_check_starcraft_udp(struct ndpi_detection_module_struct* ndpi_struct, struct ndpi_flow_struct* flow) +static u_int8_t ndpi_check_starcraft_udp(struct ndpi_detection_module_struct* ndpi_struct, struct ndpi_flow_struct* flow) { struct ndpi_packet_struct* packet = &ndpi_struct->packet; @@ -114,7 +114,7 @@ u_int8_t ndpi_check_starcraft_udp(struct ndpi_detection_module_struct* ndpi_stru return(0); } -void ndpi_search_starcraft(struct ndpi_detection_module_struct* ndpi_struct, struct ndpi_flow_struct* flow) +static void ndpi_search_starcraft(struct ndpi_detection_module_struct* ndpi_struct, struct ndpi_flow_struct* flow) { struct ndpi_packet_struct* packet = &ndpi_struct->packet; -- cgit v1.2.3