From 8fdffbf3a17ebfc8e7043264cce516d23e9f5345 Mon Sep 17 00:00:00 2001 From: Ivan Nardi <12729895+IvanNardi@users.noreply.github.com> Date: Fri, 20 Aug 2021 18:11:13 +0200 Subject: Compile everything with "-W -Wall -Wno-unused-parameter" flags (#1276) Fix all the warnings. Getting rid of "-Wno-unused-parameter" is quite complex because some parameters usage depends on compilation variable (i.e. `--enable-debug-messages`). The "-Werror" flag has been added only in Travis builds to avoid breaking the builds to users using uncommon/untested OS/compiler/enviroment. Tested on: * x86_64; Ubuntu 20.04; gcc 7,8,9,10,11; clang 7,8,9,10,11,12 * x86_64; CentOS 7.7; gcc 4.8.5 (with "--disable-gcrypt" flag) * Raspberry 4; Debian 10.10; gcc 8.3.0 --- src/lib/protocols/spotify.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'src/lib/protocols/spotify.c') diff --git a/src/lib/protocols/spotify.c b/src/lib/protocols/spotify.c index d66109016..4934953b9 100644 --- a/src/lib/protocols/spotify.c +++ b/src/lib/protocols/spotify.c @@ -89,12 +89,12 @@ static void ndpi_check_spotify(struct ndpi_detection_module_struct *ndpi_struct, //printf("%08X - %08X\n", ntohl(packet->iph->saddr), ntohl(packet->iph->daddr)); - long src_addr = ntohl(packet->iph->saddr); - long dst_addr = ntohl(packet->iph->daddr); - long src_addr_masked_22 = src_addr & 0xFFFFFC00; // */22 - long dst_addr_masked_22 = dst_addr & 0xFFFFFC00; // */22 - long src_addr_masked_24 = src_addr & 0xFFFFFF00; // */24 - long dst_addr_masked_24 = dst_addr & 0xFFFFFF00; // */24 + unsigned long src_addr = ntohl(packet->iph->saddr); + unsigned long dst_addr = ntohl(packet->iph->daddr); + unsigned long src_addr_masked_22 = src_addr & 0xFFFFFC00; // */22 + unsigned long dst_addr_masked_22 = dst_addr & 0xFFFFFC00; // */22 + unsigned long src_addr_masked_24 = src_addr & 0xFFFFFF00; // */24 + unsigned long dst_addr_masked_24 = dst_addr & 0xFFFFFF00; // */24 if( src_addr_masked_22 == 0x4E1F0800 /* 78.31.8.0 */ || dst_addr_masked_22 == 0x4E1F0800 /* 78.31.8.0 */ -- cgit v1.2.3