From 5cf3fef8f7edc14d1f62750782901b8eec997b2a Mon Sep 17 00:00:00 2001
From: Ivan Nardi <12729895+IvanNardi@users.noreply.github.com>
Date: Wed, 29 Sep 2021 13:11:32 +0200
Subject: Remove `detected_protocol_stack` field from `ndpi_packet_struct`
 (#1317)

This field is an exact copy of `ndpi_flow_struct->detected_protocol_stack[2]`:
* at the very beginning of packet dissection, the value saved in
`flow->detected_protocol_stack` is copied in `packet->detected_protocol_stack`
(via `ndpi_detection_process_packet()` -> `ndpi_init_packet_header()`)

* every time we update `flow->detected_protocol_stack` we update
`packet->detected_protocol_stack` too (via `ndpi_int_change_protocol()`
-> `ndpi_int_change_packet_protocol()`)

These two fields are always in sync: keeping the same value in two
different places is useless.
---
 src/lib/protocols/sip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'src/lib/protocols/sip.c')

diff --git a/src/lib/protocols/sip.c b/src/lib/protocols/sip.c
index 2de364873..35fcab656 100644
--- a/src/lib/protocols/sip.c
+++ b/src/lib/protocols/sip.c
@@ -186,7 +186,7 @@ void ndpi_search_sip(struct ndpi_detection_module_struct *ndpi_struct, struct nd
     NDPI_EXCLUDE_PROTO(ndpi_struct, flow);
   else {
     /* skip marked packets */
-    if(packet->detected_protocol_stack[0] != NDPI_PROTOCOL_SIP) {
+    if(flow->detected_protocol_stack[0] != NDPI_PROTOCOL_SIP) {
       if(packet->tcp_retransmission == 0) {
 	ndpi_search_sip_handshake(ndpi_struct, flow);
       }
-- 
cgit v1.2.3