From bc5be1e76cd8b3d6733f66bffe346486de89b8a0 Mon Sep 17 00:00:00 2001
From: Ivan Nardi <12729895+IvanNardi@users.noreply.github.com>
Date: Sun, 3 Oct 2021 21:38:49 +0200
Subject: Fix how some protocols handle tcp retransmissions (#1321)

Most (all?) protocols don't care about (tcp) retransmissions.

If a protocol registers itself with a
NDPI_SELECTION_BITMASK_PROTOCOL_*_WITHOUT_RETRANSMISSION value, its
callback is never triggered with a retransmitted packet.
---
 src/lib/protocols/rtmp.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

(limited to 'src/lib/protocols/rtmp.c')

diff --git a/src/lib/protocols/rtmp.c b/src/lib/protocols/rtmp.c
index 995de1c70..2f49b9faa 100644
--- a/src/lib/protocols/rtmp.c
+++ b/src/lib/protocols/rtmp.c
@@ -78,15 +78,11 @@ static void ndpi_check_rtmp(struct ndpi_detection_module_struct *ndpi_struct, st
 
 void ndpi_search_rtmp(struct ndpi_detection_module_struct *ndpi_struct, struct ndpi_flow_struct *flow)
 {
-  struct ndpi_packet_struct *packet = &flow->packet;
-
   NDPI_LOG_DBG(ndpi_struct, "search RTMP\n");
 
   /* skip marked packets */
   if (flow->detected_protocol_stack[0] != NDPI_PROTOCOL_RTMP) {
-    if (packet->tcp_retransmission == 0) {
-      ndpi_check_rtmp(ndpi_struct, flow);
-    }
+    ndpi_check_rtmp(ndpi_struct, flow);
   }
 }
 
-- 
cgit v1.2.3