From d65d6324b11e86824f8ecf4eaa36a02d186a0b23 Mon Sep 17 00:00:00 2001 From: lns Date: Thu, 2 Jun 2022 12:32:09 +0200 Subject: Fix heap buffer overflow mentioned in #1574. Signed-off-by: lns --- src/lib/protocols/irc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/lib/protocols/irc.c') diff --git a/src/lib/protocols/irc.c b/src/lib/protocols/irc.c index 33c41a4c3..80de27417 100644 --- a/src/lib/protocols/irc.c +++ b/src/lib/protocols/irc.c @@ -517,7 +517,7 @@ void ndpi_search_irc_tcp(struct ndpi_detection_module_struct *ndpi_struct, struc for (i = 0; i < packet->parsed_lines; i++) { if (packet->line[i].len > 6 && memcmp(packet->line[i].ptr, "NOTICE ", 7) == 0) { NDPI_LOG_DBG2(ndpi_struct, "NOTICE"); - for (j = 7; j < packet->line[i].len - 8; j++) { + for (j = 7; j < packet->line[i].len - 9; j++) { if (packet->line[i].ptr[j] == ':') { if (memcmp(&packet->line[i].ptr[j + 1], "DCC SEND ", 9) == 0 || memcmp(&packet->line[i].ptr[j + 1], "DCC CHAT ", 9) == 0) { -- cgit v1.2.3