From 5f99433ee75cd6acc4e73fd9de132b138be12a50 Mon Sep 17 00:00:00 2001 From: Luca Deri Date: Tue, 22 Sep 2020 08:56:35 +0200 Subject: Minor UA handling improvement to avoid heap-overflow --- src/lib/protocols/http.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/lib/protocols/http.c') diff --git a/src/lib/protocols/http.c b/src/lib/protocols/http.c index 983a53b1c..2cc42edad 100644 --- a/src/lib/protocols/http.c +++ b/src/lib/protocols/http.c @@ -347,7 +347,7 @@ int http_process_user_agent(struct ndpi_detection_module_struct *ndpi_struct, flow->http.user_agent = ndpi_malloc(len); if(flow->http.user_agent) { - strncpy(flow->http.user_agent, (char*)ua_ptr, ua_ptr_len); + memcpy(flow->http.user_agent, (char*)ua_ptr, ua_ptr_len); flow->http.user_agent[ua_ptr_len] = '\0'; ndpi_check_user_agent(ndpi_struct, flow, flow->http.user_agent); -- cgit v1.2.3