From 0a47f745cc87f967f0d8513b4178321e21a02efc Mon Sep 17 00:00:00 2001 From: Ivan Nardi <12729895+IvanNardi@users.noreply.github.com> Date: Mon, 5 Sep 2022 13:59:51 +0200 Subject: Avoid useless host automa lookup (#1724) The host automa is used for two tasks: * protocol sub-classification (obviously); * DGA evaluation: the idea is that if a domain is present in this automa, it can't be a DGA, regardless of its format/name. In most dissectors both checks are executed, i.e. the code is something like: ``` ndpi_match_host_subprotocol(..., flow->host_server_name, ...); ndpi_check_dga_name(..., flow->host_server_name,...); ``` In that common case, we can perform only one automa lookup: if we check the sub-classification before the DGA, we can avoid the second lookup in the DGA function itself. --- src/lib/protocols/fastcgi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/lib/protocols/fastcgi.c') diff --git a/src/lib/protocols/fastcgi.c b/src/lib/protocols/fastcgi.c index 9fad2c044..f70bd6cf5 100644 --- a/src/lib/protocols/fastcgi.c +++ b/src/lib/protocols/fastcgi.c @@ -212,7 +212,7 @@ void ndpi_search_fastcgi(struct ndpi_detection_module_struct *ndpi_struct, strlen(flow->host_server_name), &ret_match, NDPI_PROTOCOL_FASTCGI); ndpi_check_dga_name(ndpi_struct, flow, - flow->host_server_name, 1); + flow->host_server_name, 1, 0); if(ndpi_is_valid_hostname(flow->host_server_name, strlen(flow->host_server_name)) == 0) { char str[128]; -- cgit v1.2.3