From 1deae1132bb80469665c10f101ac46bfd75e83e4 Mon Sep 17 00:00:00 2001
From: Ivan Nardi <12729895+IvanNardi@users.noreply.github.com>
Date: Sun, 9 May 2021 15:11:05 +0200
Subject: Fix some warnings (#1181)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

```
In file included from protocols/fasttrack.c:29:
../include/ndpi_api.h:1504:3: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
 1504 |   const ndpi_risk_severity ndpi_risk2severity(ndpi_risk_enum risk);
      |   ^~~~~
In file included from protocols/amazon_video.c:28:
../include/ndpi_api.h:1504:3: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
 1504 |   const ndpi_risk_severity ndpi_risk2severity(ndpi_risk_enum risk);
      |   ^~~~~

...

ndpi_utils.c: In function ‘ndpi_risk2severity’:
ndpi_utils.c:1834:1: warning: control reaches end of non-void function [-Wreturn-type]
 1834 | }
      | ^
```
---
 src/lib/ndpi_utils.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

(limited to 'src/lib/ndpi_utils.c')

diff --git a/src/lib/ndpi_utils.c b/src/lib/ndpi_utils.c
index f59a9d773..07b1cbb02 100644
--- a/src/lib/ndpi_utils.c
+++ b/src/lib/ndpi_utils.c
@@ -1788,7 +1788,7 @@ const char* ndpi_risk2str(ndpi_risk_enum risk) {
 
 /* ******************************************************************** */
 
-const ndpi_risk_severity ndpi_risk2severity(ndpi_risk_enum risk) {
+ndpi_risk_severity ndpi_risk2severity(ndpi_risk_enum risk) {
   switch(risk) {
   case NDPI_NO_RISK:
   case NDPI_MAX_RISK:
@@ -1831,6 +1831,10 @@ const ndpi_risk_severity ndpi_risk2severity(ndpi_risk_enum risk) {
   case NDPI_BINARY_APPLICATION_TRANSFER:
     return(NDPI_RISK_SEVERE);
   }
+
+  /* We have added all possible ndpi_risk_enum values in the switch,
+     but the compiler complains anyway... Try to silence it */
+  return(NDPI_RISK_LOW);
 }
 
 /* ******************************************************************** */
-- 
cgit v1.2.3