From 8fdffbf3a17ebfc8e7043264cce516d23e9f5345 Mon Sep 17 00:00:00 2001
From: Ivan Nardi <12729895+IvanNardi@users.noreply.github.com>
Date: Fri, 20 Aug 2021 18:11:13 +0200
Subject: Compile everything with "-W -Wall -Wno-unused-parameter" flags
 (#1276)

Fix all the warnings.

Getting rid of "-Wno-unused-parameter" is quite complex because some
parameters usage depends on compilation variable (i.e.
`--enable-debug-messages`).

The "-Werror" flag has been added only in Travis builds to avoid
breaking the builds to users using uncommon/untested
OS/compiler/enviroment.

Tested on:
* x86_64; Ubuntu 20.04; gcc 7,8,9,10,11; clang 7,8,9,10,11,12
* x86_64; CentOS 7.7; gcc 4.8.5 (with "--disable-gcrypt" flag)
* Raspberry 4; Debian 10.10; gcc 8.3.0
---
 src/include/ndpi_api.h.in   | 2 +-
 src/include/ndpi_typedefs.h | 4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)

(limited to 'src/include')

diff --git a/src/include/ndpi_api.h.in b/src/include/ndpi_api.h.in
index 4701d85c4..064b4f27d 100644
--- a/src/include/ndpi_api.h.in
+++ b/src/include/ndpi_api.h.in
@@ -687,7 +687,7 @@ extern "C" {
    *
    * @par  ndpi_mod = the detection module
    */
-  void ndpi_dump_risks_score();
+  void ndpi_dump_risks_score(void);
 
   /**
    * Read a file and load the protocols
diff --git a/src/include/ndpi_typedefs.h b/src/include/ndpi_typedefs.h
index 38613886f..83e9376b6 100644
--- a/src/include/ndpi_typedefs.h
+++ b/src/include/ndpi_typedefs.h
@@ -1512,12 +1512,14 @@ struct ndpi_flow_struct {
   struct ndpi_id_struct *dst;
 };
 
+#define NDPI_PROTOCOL_DEFAULT_LEVEL	0
+
 typedef struct {
   char *string_to_match, *proto_name;
   u_int16_t protocol_id;
   ndpi_protocol_category_t protocol_category;
   ndpi_protocol_breed_t protocol_breed;
-  int level; /* 0 by default */
+  int level; /* NDPI_PROTOCOL_DEFAULT_LEVEL (0) by default */
 } ndpi_protocol_match;
 
 typedef struct {
-- 
cgit v1.2.3