From 8b1c68aed3228ff4e6b0c4e592c45c1426c51ace Mon Sep 17 00:00:00 2001
From: Stuart Reilly <rs576h@vyatta.att-mail.com>
Date: Fri, 12 Jul 2019 15:59:11 +0100
Subject: Add compiler warnings and fix them

---
 example/ndpiReader.c | 11 ++++-------
 example/ndpi_util.c  |  2 +-
 2 files changed, 5 insertions(+), 8 deletions(-)

(limited to 'example')

diff --git a/example/ndpiReader.c b/example/ndpiReader.c
index 003737212..73dfdf051 100644
--- a/example/ndpiReader.c
+++ b/example/ndpiReader.c
@@ -2781,7 +2781,7 @@ void bpf_filter_pkt_peak_filter(json_object **jObj_bpfFilter,
     int l;
 
     if(port_array[0] != INIT_VAL)
-      strncat(filter, " and not (src ", sizeof(" and not (src "));
+      strncat(filter, " and not (src ", sizeof(filter)/sizeof(char));
     else
       strcpy(filter, "not (src ");
 
@@ -2808,7 +2808,7 @@ void bpf_filter_pkt_peak_filter(json_object **jObj_bpfFilter,
     int l;
 
     if(port_array[0] != INIT_VAL || src_host_array[0] != NULL)
-      strncat(filter, " and not (dst ", sizeof(" and not (dst "));
+      strncat(filter, " and not (dst ", sizeof(filter)/sizeof(char));
     else
       strcpy(filter, "not (dst ");
 
@@ -2955,7 +2955,6 @@ void bpf_filter_port_array_add(int filter_array[], int size, int port) {
 float getAverage(struct json_object *jObj_stat, char *field){
   json_object *field_stat;
   json_bool res;
-  float average;
   float sum = 0;
   int r;
   int j = 0;
@@ -3003,11 +3002,11 @@ float getStdDeviation(struct json_object *jObj_stat, float average, char *field)
   json_object *field_stat;
   json_bool res;
   float sum = 0;
-  int j;
+  int j = 0;
   int r;
 
   if((r = strcmp(field, "top.scanner.stats")) == 0){
-    for(j=0; j<json_object_array_length(jObj_stat); j++) {
+    for(; j<json_object_array_length(jObj_stat); j++) {
       field_stat = json_object_array_get_idx(jObj_stat, j);
       json_object *jObj_tot_flows_number;
 
@@ -3192,7 +3191,6 @@ static void produceBpfFilter(char *filePath) {
   const char *filterPktDstHosts[48];
   struct stat statbuf;
   FILE *fp = NULL;
-  char *fileName;
   char _filterFilePath[1024];
   json_object *jObj_bpfFilter;
   void *fmap;
@@ -3288,7 +3286,6 @@ static void produceBpfFilter(char *filePath) {
   }
 
 
-  fileName = basename(filePath);
   snprintf(_filterFilePath, sizeof(_filterFilePath), "%s.bpf", filePath);
 
   if((fp = fopen(_filterFilePath,"w")) == NULL) {
diff --git a/example/ndpi_util.c b/example/ndpi_util.c
index b4d588c67..c055df317 100644
--- a/example/ndpi_util.c
+++ b/example/ndpi_util.c
@@ -732,7 +732,7 @@ struct ndpi_proto ndpi_workflow_process_packet(struct ndpi_workflow * workflow,
   u_int16_t ip_offset = 0, ip_len;
   u_int16_t frag_off = 0, vlan_id = 0;
   u_int8_t proto = 0;
-  u_int32_t label;
+  /*u_int32_t label;*/
 
   /* counters */
   u_int8_t vlan_packet = 0;
-- 
cgit v1.2.3