aboutsummaryrefslogtreecommitdiff
path: root/src/lib/protocols/someip.c
diff options
context:
space:
mode:
Diffstat (limited to 'src/lib/protocols/someip.c')
-rw-r--r--src/lib/protocols/someip.c25
1 files changed, 2 insertions, 23 deletions
diff --git a/src/lib/protocols/someip.c b/src/lib/protocols/someip.c
index 50a823ec0..c99e8d27c 100644
--- a/src/lib/protocols/someip.c
+++ b/src/lib/protocols/someip.c
@@ -71,12 +71,6 @@ enum MAGIC_COOKIE_CONSTANTS{
MC_INTERFACE_VERSION = 0x01
};
-enum DEFAULT_PROTOCOL_PORTS{
- PORT_DEFAULT_CLIENT = 30491,
- PORT_DEFAULT_SERVER = 30501,
- PORT_DEFAULT_SD = 30490
-};
-
/**
* Entry point when protocol is identified.
*/
@@ -151,6 +145,7 @@ void ndpi_search_someip (struct ndpi_detection_module_struct *ndpi_struct,
u_int8_t interface_version = (packet->payload[13]);
u_int8_t message_type = (u_int8_t) (packet->payload[14]);
+ message_type &= (~0x20); /* Clear TP bit */
NDPI_LOG_DBG2(ndpi_struct,"====>>>> SOME/IP message type: [%d]\n",message_type);
if ((message_type != SOMEIP_REQUEST) && (message_type != SOMEIP_REQUEST_NO_RETURN) && (message_type != SOMEIP_NOTIFICATION) && (message_type != SOMEIP_REQUEST_ACK) &&
@@ -201,23 +196,7 @@ void ndpi_search_someip (struct ndpi_detection_module_struct *ndpi_struct,
NDPI_LOG_DBG2(ndpi_struct, "SOME/IP-SD currently not supported [%d]\n", message_type);
}
- //Filtering by port.
- //This check is NOT a 100% thing - these ports are mentioned in the documentation but the documentation also states they haven't been approved by IANA yet, and that the user is free to use different ports.
- //This is is PURELY for demo purposes and the rest of the check must be filled in later on!
- if (flow->l4_proto == IPPROTO_UDP){
- if ((packet->udp->dest == ntohs(PORT_DEFAULT_CLIENT)) || (packet->udp->dest == ntohs(PORT_DEFAULT_SERVER)) || (packet->udp->dest == ntohs(PORT_DEFAULT_SD))) {
- ndpi_int_someip_add_connection(ndpi_struct, flow);
- return;
- }
- }
- if (flow->l4_proto == IPPROTO_TCP){
- if ((packet->tcp->dest == ntohs(PORT_DEFAULT_CLIENT)) || (packet->tcp->dest == ntohs(PORT_DEFAULT_SERVER))) {
- ndpi_int_someip_add_connection(ndpi_struct, flow);
- return;
- }
- }
-
- NDPI_EXCLUDE_PROTO(ndpi_struct, flow);
+ ndpi_int_someip_add_connection(ndpi_struct, flow);
}
/**
* Entry point for the ndpi library