diff options
author | Nardi Ivan <nardi.ivan@gmail.com> | 2022-07-28 21:01:16 +0200 |
---|---|---|
committer | Toni <matzeton@googlemail.com> | 2022-09-04 17:22:19 +0200 |
commit | b9cb3917564404367f35f54eafaaab1e28ce266f (patch) | |
tree | df0f491a2c8401109e5050e54a6518dbcb5175b2 /tests/pcap | |
parent | 7578d02de9f196f73e2de47c457a1edc7f4c248d (diff) |
Add support to opportunistic TLS
A lot of protocols provide the feature to upgrade their plain text
connections to an encrypted one, via some kind of "STARTTLS" command.
Add generic code to support this extension, and allow dissection of the
entire TLS handshake.
As examples, SMTP, POP, IMAP and FTP dissectors have been updated.
Since this feature requires to process more packets per flow, add the
possibility to disable it.
Fix some log messages.
Slight improvement on TCP sequence number tracking.
As a side effect, this commit fix also a memory leak found by
oss-fuzzer
```
==108966==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 22 byte(s) in 1 object(s) allocated from:
#0 0x55f8b367a0be in malloc (/home/ivan/svnrepos/nDPI/fuzz/fuzz_ndpi_reader_with_main+0x5480be) (BuildId: 94debacb4a6784c30420ab748c8bf3cc59621063)
#1 0x55f8b36e1345 in ndpi_malloc_wrapper /home/ivan/svnrepos/nDPI/example/reader_util.c:321:10
#2 0x55f8b379c7d2 in ndpi_malloc /home/ivan/svnrepos/nDPI/src/lib/ndpi_main.c:212:25
#3 0x55f8b379cb18 in ndpi_strdup /home/ivan/svnrepos/nDPI/src/lib/ndpi_main.c:279:13
#4 0x55f8b386ce46 in processClientServerHello /home/ivan/svnrepos/nDPI/src/lib/protocols/tls.c:2153:34
#5 0x55f8b385ebf7 in processTLSBlock /home/ivan/svnrepos/nDPI/src/lib/protocols/tls.c:867:5
#6 0x55f8b39e708c in ndpi_extra_search_mail_smtp_tcp /home/ivan/svnrepos/nDPI/src/lib/protocols/mail_smtp.c:422:9
#7 0x55f8b37e636c in ndpi_process_extra_packet /home/ivan/svnrepos/nDPI/src/lib/ndpi_main.c:5884:9
#8 0x55f8b37edc05 in ndpi_detection_process_packet /home/ivan/svnrepos/nDPI/src/lib/ndpi_main.c:6276:5
#9 0x55f8b3701ffc in packet_processing /home/ivan/svnrepos/nDPI/example/reader_util.c:1619:31
#10 0x55f8b36faf14 in ndpi_workflow_process_packet /home/ivan/svnrepos/nDPI/example/reader_util.c:2189:10
#11 0x55f8b36b6a50 in LLVMFuzzerTestOneInput /home/ivan/svnrepos/nDPI/fuzz/fuzz_ndpi_reader.c:107:7
```
See: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=50765
Diffstat (limited to 'tests/pcap')
-rw-r--r-- | tests/pcap/pop3_stls.pcap | bin | 0 -> 12061 bytes |
-rw-r--r-- | tests/pcap/smtp-starttls.pcap | bin | 9003 -> 15960 bytes |
-rw-r--r-- | tests/pcap/tls_multiple_synack_different_seq.pcapng | bin | 0 -> 6984 bytes |
3 files changed, 0 insertions, 0 deletions
diff --git a/tests/pcap/pop3_stls.pcap b/tests/pcap/pop3_stls.pcap Binary files differnew file mode 100644 index 000000000..b56dffac6 --- /dev/null +++ b/tests/pcap/pop3_stls.pcap diff --git a/tests/pcap/smtp-starttls.pcap b/tests/pcap/smtp-starttls.pcap Binary files differindex 493751539..4a37ecc51 100644 --- a/tests/pcap/smtp-starttls.pcap +++ b/tests/pcap/smtp-starttls.pcap diff --git a/tests/pcap/tls_multiple_synack_different_seq.pcapng b/tests/pcap/tls_multiple_synack_different_seq.pcapng Binary files differnew file mode 100644 index 000000000..3b9b621e4 --- /dev/null +++ b/tests/pcap/tls_multiple_synack_different_seq.pcapng |