diff options
| author | Ivan Nardi <12729895+IvanNardi@users.noreply.github.com> | 2021-09-16 14:34:59 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-09-16 14:34:59 +0200 |
| commit | 6325aebda6c583d8acb21e664ad805418bb4e747 (patch) | |
| tree | 6ce4e598b98f7772a9bb68d30bdcea9f6309b90a /tests/do.sh.in | |
| parent | 978c9cfda376d008aa4801205f3dd887638d5053 (diff) | |
TLS: avoid zeroing large structures (#1300)
Zeroing large structures (i.e. size > KB) is quite costly (from a CPU point
of view): we can safely avoid doing that for a couple of big structures.
Standard and Valgrind tests have been diverging quite a lot: it is time
to re-sync them. Use the same script and enable Valgrind via an
enviroment variable:
NDPI_TESTS_VALGRIND=1 ./tests/do.sh
Diffstat (limited to 'tests/do.sh.in')
| -rwxr-xr-x | tests/do.sh.in | 12 |
1 files changed, 9 insertions, 3 deletions
diff --git a/tests/do.sh.in b/tests/do.sh.in index 01fad8497..cf14e653c 100755 --- a/tests/do.sh.in +++ b/tests/do.sh.in @@ -4,9 +4,15 @@ cd "$(dirname "${0}")" FUZZY_TESTING_ENABLED=@BUILD_FUZZTARGETS@ +#Remember: valgrind and *SAN are incompatible! +VALGRIND="" +if [ "$NDPI_TESTS_VALGRIND" = "1" ]; then + VALGRIND="valgrind -q --leak-check=full" +fi + GCRYPT_ENABLED=@GCRYPT_ENABLED@ GCRYPT_PCAPS="gquic.pcap quic-23.pcap quic-24.pcap quic-27.pcap quic-28.pcap quic-29.pcap quic-mvfst-22.pcap quic-mvfst-27.pcapng quic-mvfst-exp.pcap quic_q50.pcap quic_t50.pcap quic_t51.pcap quic_0RTT.pcap quic_interop_V.pcapng quic-33.pcapng doq.pcapng doq_adguard.pcapng dlt_ppp.pcap os_detected.pcapng quic_frags_ch_out_of_order_same_packet_craziness.pcapng quic_frags_ch_in_multiple_packets.pcapng" -READER="../example/ndpiReader -p ../example/protos.txt -c ../example/categories.txt -r ../example/risky_domains.txt -j ../example/ja3_fingerprints.csv -S ../example/sha1_fingerprints.csv" +READER="$VALGRIND ../example/ndpiReader -p ../example/protos.txt -c ../example/categories.txt -r ../example/risky_domains.txt -j ../example/ja3_fingerprints.csv -S ../example/sha1_fingerprints.csv" RC=0 PCAPS=`cd pcap; /bin/ls *.pcap *.pcapng` @@ -61,9 +67,9 @@ check_results() { NUM_DIFF=`diff result/$f.out /tmp/reader.out | wc -l` if [ $NUM_DIFF -eq 0 ]; then - printf "%-32s\tOK\n" "$f" + printf "%-48s\tOK\n" "$f" else - printf "%-32s\tERROR\n" "$f" + printf "%-48s\tERROR\n" "$f" echo "$CMD [old vs new]" diff result/$f.out /tmp/reader.out RC=1 |