aboutsummaryrefslogtreecommitdiff
path: root/tests/dga
diff options
context:
space:
mode:
authorIvan Nardi <12729895+IvanNardi@users.noreply.github.com>2022-09-05 13:59:51 +0200
committerGitHub <noreply@github.com>2022-09-05 13:59:51 +0200
commit0a47f745cc87f967f0d8513b4178321e21a02efc (patch)
treebfa7610e8c35281d8c94d35aacd1f67908355721 /tests/dga
parent01028ee77921cb21dee8b0e5f1f912ffd304244a (diff)
Avoid useless host automa lookup (#1724)
The host automa is used for two tasks: * protocol sub-classification (obviously); * DGA evaluation: the idea is that if a domain is present in this automa, it can't be a DGA, regardless of its format/name. In most dissectors both checks are executed, i.e. the code is something like: ``` ndpi_match_host_subprotocol(..., flow->host_server_name, ...); ndpi_check_dga_name(..., flow->host_server_name,...); ``` In that common case, we can perform only one automa lookup: if we check the sub-classification before the DGA, we can avoid the second lookup in the DGA function itself.
Diffstat (limited to 'tests/dga')
-rw-r--r--tests/dga/dga_evaluate.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/dga/dga_evaluate.c b/tests/dga/dga_evaluate.c
index fb32075db..98cc6a2b1 100644
--- a/tests/dga/dga_evaluate.c
+++ b/tests/dga/dga_evaluate.c
@@ -80,7 +80,7 @@ int main(int argc, char **argv) {
while(fgets(buffer, sizeof(buffer), fd) != NULL) {
char *hostname = strtok(buffer, "\n");
- if(ndpi_check_dga_name(ndpi_str, NULL, hostname, 1)) {
+ if(ndpi_check_dga_name(ndpi_str, NULL, hostname, 1, 1)) {
if(verbose)
printf("%10s\t%s\n", "[DGA]", hostname);