Add BFCP protocol support (#2401)

5 files changed, 98 insertions, 5 deletions

diff --git a/src/include/ndpi_private.h b/src/include/ndpi_private.h
index 75668b866..42b31d7fe 100644
--- a/src/include/ndpi_private.h
+++ b/src/include/ndpi_private.h
@@ -917,6 +917,7 @@ void init_lolwildrift_dissector(struct ndpi_detection_module_struct *ndpi_struct
 void init_teso_dissector(struct ndpi_detection_module_struct *ndpi_struct, u_int32_t *id);
 void init_ldp_dissector(struct ndpi_detection_module_struct *ndpi_struct, u_int32_t *id);
 void init_knxnet_ip_dissector(struct ndpi_detection_module_struct *ndpi_struct, u_int32_t *id);
+void init_bfcp_dissector(struct ndpi_detection_module_struct *ndpi_struct, u_int32_t *id);
 
 #endif
 
diff --git a/src/include/ndpi_protocol_ids.h b/src/include/ndpi_protocol_ids.h
index a7b295924..39a091ddd 100644
--- a/src/include/ndpi_protocol_ids.h
+++ b/src/include/ndpi_protocol_ids.h
@@ -60,7 +60,7 @@ typedef enum {
   NDPI_PROTOCOL_MAIL_SMTPS            = 29,
   NDPI_PROTOCOL_DTLS                  = 30,
   NDPI_PROTOCOL_UBNTAC2               = 31, /* Ubiquity UBNT AirControl = 2 */
-  NDPI_PROTOCOL_FREE_32               = 32, /* FREE */
+  NDPI_PROTOCOL_BFCP                  = 32,
   NDPI_PROTOCOL_YANDEX_MAIL           = 33,
   NDPI_PROTOCOL_YANDEX_MUSIC          = 34,
   NDPI_PROTOCOL_GNUTELLA              = 35,
diff --git a/src/include/ndpi_typedefs.h b/src/include/ndpi_typedefs.h
index 86c7df8ab..f5e6ac803 100644
--- a/src/include/ndpi_typedefs.h
+++ b/src/include/ndpi_typedefs.h
@@ -1490,6 +1490,10 @@ struct ndpi_flow_struct {
   /* NDPI_PROTOCOL_TEAMVIEWER */
   u_int8_t teamviewer_stage : 3;
 
+  /* NDPI_PROTOCOL_BFCP */
+  u_int8_t bfcp_stage:1;
+  u_int32_t bfcp_conference_id;
+
   /* NDPI_PROTOCOL_OPENVPN */
   u_int8_t ovpn_session_id[2][8];
 
diff --git a/src/lib/ndpi_main.c b/src/lib/ndpi_main.c
index 5056cf99e..db3814015 100644
--- a/src/lib/ndpi_main.c
+++ b/src/lib/ndpi_main.c
@@ -1140,10 +1140,6 @@ static void ndpi_init_protocol_defaults(struct ndpi_detection_module_struct *ndp
 			  "VMware", NDPI_PROTOCOL_CATEGORY_REMOTE_ACCESS,
 			  ndpi_build_default_ports(ports_a, 903, 0, 0, 0, 0) /* TCP */,
 			  ndpi_build_default_ports(ports_b, 902, 903, 0, 0, 0) /* UDP */);
-  ndpi_set_proto_defaults(ndpi_str, 1 /* cleartext */, 0 /* nw proto */, NDPI_PROTOCOL_POTENTIALLY_DANGEROUS, NDPI_PROTOCOL_FREE_32,
-			  "Free32", NDPI_PROTOCOL_CATEGORY_MEDIA,
-			  ndpi_build_default_ports(ports_a, 0, 0, 0, 0, 0) /* TCP */,
-			  ndpi_build_default_ports(ports_b, 0, 0, 0, 0, 0) /* UDP */);
   ndpi_set_proto_defaults(ndpi_str, 1 /* cleartext */, 0 /* nw proto */, NDPI_PROTOCOL_POTENTIALLY_DANGEROUS, NDPI_PROTOCOL_GNUTELLA,
 			  "Gnutella", NDPI_PROTOCOL_CATEGORY_DOWNLOAD_FT,
 			  ndpi_build_default_ports(ports_a, 0, 0, 0, 0, 0) /* TCP */,
@@ -2308,6 +2304,10 @@ static void ndpi_init_protocol_defaults(struct ndpi_detection_module_struct *ndp
 			  "Free149", NDPI_PROTOCOL_CATEGORY_VOIP,
 			  ndpi_build_default_ports(ports_a, 0, 0, 0, 0, 0) /* TCP */,
 			  ndpi_build_default_ports(ports_b, 0, 0, 0, 0, 0) /* UDP */);
+  ndpi_set_proto_defaults(ndpi_str, 1 /* cleartext */, 0 /* nw proto */, NDPI_PROTOCOL_ACCEPTABLE, NDPI_PROTOCOL_BFCP,
+			  "BFCP", NDPI_PROTOCOL_CATEGORY_VIDEO,
+			  ndpi_build_default_ports(ports_a, 0, 0, 0, 0, 0) /* TCP */,
+			  ndpi_build_default_ports(ports_b, 0, 0, 0, 0, 0) /* UDP */);
 
 #ifdef CUSTOM_NDPI_PROTOCOLS
 #include "../../../nDPI-custom/custom_ndpi_main.c"
@@ -6202,6 +6202,9 @@ static int ndpi_callback_init(struct ndpi_detection_module_struct *ndpi_str) {
   /* KNXnet/IP */
   init_knxnet_ip_dissector(ndpi_str, &a);
 
+  /* Binary Floor Control Protocol */
+  init_bfcp_dissector(ndpi_str, &a);
+
 #ifdef CUSTOM_NDPI_PROTOCOLS
 #include "../../../nDPI-custom/custom_ndpi_main_init.c"
 #endif
diff --git a/src/lib/protocols/bfcp.c b/src/lib/protocols/bfcp.c
new file mode 100644
index 000000000..b2bd52bdb
--- /dev/null
+++ b/src/lib/protocols/bfcp.c
@@ -0,0 +1,85 @@
+/*
+ * bfcp.c
+ *
+ * Binary Floor Control Protocol
+ * 
+ * Copyright (C) 2024 - ntop.org
+ * Copyright (C) 2024 - V.G <v.gavrilov@securitycode.ru>
+ *
+ * This file is part of nDPI, an open source deep packet inspection
+ * library based on the OpenDPI and PACE technology by ipoque GmbH
+ *
+ * nDPI is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Lesser General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * nDPI is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with nDPI.  If not, see <http://www.gnu.org/licenses/>.
+ * 
+ */
+
+#include "ndpi_protocol_ids.h"
+
+#define NDPI_CURRENT_PROTO NDPI_PROTOCOL_BFCP
+
+#include "ndpi_api.h"
+#include "ndpi_private.h"
+
+static void ndpi_search_bfcp(struct ndpi_detection_module_struct *ndpi_struct,
+                             struct ndpi_flow_struct *flow)
+{
+  struct ndpi_packet_struct const * const packet = &ndpi_struct->packet;
+
+  NDPI_LOG_DBG(ndpi_struct, "search BFCP\n");
+
+  if (packet->payload_packet_len < 12) {
+    goto not_bfcp;
+  }
+
+  u_int8_t version = (packet->payload[0] >> 5) & 0x07;
+  u_int8_t reserved = (packet->payload[0] >> 3) & 0x01;
+
+  if (version != 1 || reserved != 0) {
+    goto not_bfcp;
+  }
+
+  u_int8_t primitive = packet->payload[1];
+  if (primitive < 1 || primitive > 17) {
+    goto not_bfcp;
+  }
+
+  u_int32_t conference_id = ntohl(get_u_int32_t(packet->payload, 4));
+  if (!flow->bfcp_stage) {
+    flow->bfcp_conference_id = conference_id;
+    flow->bfcp_stage = 1;
+    return;
+  }
+
+  if (flow->bfcp_stage && flow->bfcp_conference_id == conference_id) {
+    NDPI_LOG_INFO(ndpi_struct, "found BFCP\n");
+    ndpi_set_detected_protocol(ndpi_struct, flow, NDPI_PROTOCOL_BFCP,
+                               NDPI_PROTOCOL_UNKNOWN, NDPI_CONFIDENCE_DPI);
+    return;
+  }
+
+not_bfcp:
+  NDPI_EXCLUDE_PROTO(ndpi_struct, flow);
+}
+
+void init_bfcp_dissector(struct ndpi_detection_module_struct *ndpi_struct, u_int32_t *id)
+{
+  ndpi_set_bitmask_protocol_detection("BFCP", ndpi_struct, *id,
+                                      NDPI_PROTOCOL_BFCP,
+                                      ndpi_search_bfcp,
+                                      NDPI_SELECTION_BITMASK_PROTOCOL_V4_V6_TCP_OR_UDP_WITH_PAYLOAD_WITHOUT_RETRANSMISSION,
+                                      SAVE_DETECTION_BITMASK_AS_UNKNOWN,
+                                      ADD_TO_DETECTION_BITMASK);
+
+  *id += 1;
+}