aboutsummaryrefslogtreecommitdiff
path: root/src/lib/protocols
diff options
context:
space:
mode:
authorMichele Campus <fci1908@gmail.com>2016-05-24 22:04:33 +0200
committerMichele Campus <fci1908@gmail.com>2016-05-24 22:04:33 +0200
commita0fe6665b24f6a7987d5cb6aed44e1ef461b8be1 (patch)
tree4a813c58f1f47ece6fed47a7bdb0c8e1ec20b0ad /src/lib/protocols
parentb05907f592e59d30461817269ded7f2141e7207a (diff)
parentbae6a09a7c200d216cdfea526fb9460cc070dbd6 (diff)
Merge pull request #203 from alagoutte/scan-build
fix warning found by Clang Analyzer (scan-build)
Diffstat (limited to 'src/lib/protocols')
-rw-r--r--src/lib/protocols/bittorrent.c1
-rw-r--r--src/lib/protocols/ftp_data.c1
-rw-r--r--src/lib/protocols/rtcp.c1
3 files changed, 0 insertions, 3 deletions
diff --git a/src/lib/protocols/bittorrent.c b/src/lib/protocols/bittorrent.c
index 8213d3b45..6ac9ec69a 100644
--- a/src/lib/protocols/bittorrent.c
+++ b/src/lib/protocols/bittorrent.c
@@ -135,7 +135,6 @@ static u_int8_t ndpi_int_search_bittorrent_tcp_zero(struct ndpi_detection_module
|| memcmp(packet->payload, "POST ", 5) == 0)) {
const u_int8_t *ptr = &packet->payload[4];
u_int16_t len = packet->payload_packet_len - 4;
- a = 0;
/* parse complete get packet here into line structure elements */
diff --git a/src/lib/protocols/ftp_data.c b/src/lib/protocols/ftp_data.c
index 32774899c..7daf9190d 100644
--- a/src/lib/protocols/ftp_data.c
+++ b/src/lib/protocols/ftp_data.c
@@ -230,7 +230,6 @@ static void ndpi_check_ftp_data(struct ndpi_detection_module_struct *ndpi_struct
}
void ndpi_search_ftp_data(struct ndpi_detection_module_struct *ndpi_struct, struct ndpi_flow_struct *flow) {
- struct ndpi_packet_struct *packet = &flow->packet;
/* Break after 20 packets. */
if(flow->packet_counter > 20) {
diff --git a/src/lib/protocols/rtcp.c b/src/lib/protocols/rtcp.c
index be4aee669..cc6265220 100644
--- a/src/lib/protocols/rtcp.c
+++ b/src/lib/protocols/rtcp.c
@@ -48,7 +48,6 @@ void ndpi_search_rtcp(struct ndpi_detection_module_struct *ndpi_struct, struct n
offset += rtcp_section_len;
}
- sport = ntohs(packet->udp->source), dport = ntohs(packet->udp->dest);
NDPI_LOG(NDPI_PROTOCOL_RTCP, ndpi_struct, NDPI_LOG_DEBUG, "calculating dport over udp.\n");
/* TODO changed a pair of length condition to the && from ||. Is it correct? */
if(((packet->payload_packet_len >= 28 && packet->payload_packet_len <= 1200) &&