aboutsummaryrefslogtreecommitdiff
path: root/src/lib/protocols/tls.c
diff options
context:
space:
mode:
authorIvan Nardi <12729895+IvanNardi@users.noreply.github.com>2021-05-09 15:10:14 +0200
committerGitHub <noreply@github.com>2021-05-09 15:10:14 +0200
commit12c6ab768d716aa54a343a82ac333c9c5fb02af4 (patch)
tree702ffe2fbb200024b03cdd108427f72c2a9a052f /src/lib/protocols/tls.c
parent8c28613eb27983272912d0b99e510eff5416ac60 (diff)
TLS: fix another use-of-uninitialized-value error in ClientHello parsing (#1179)
Error detected with valgrind. ==13127== Conditional jump or move depends on uninitialised value(s) ==13127== at 0x483EF58: strlen (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so) ==13127== by 0x1A93B6: ndpi_strdup (ndpi_main.c:159) ==13127== by 0x1C07CC: processClientServerHello (tls.c:1678) ==13127== by 0x1C0C4C: processTLSBlock (tls.c:712) ==13127== by 0x1C0C4C: ndpi_search_tls_tcp.part.0 (tls.c:849) See also 8c3674e9
Diffstat (limited to 'src/lib/protocols/tls.c')
1 files changed, 2 insertions, 1 deletions
diff --git a/src/lib/protocols/tls.c b/src/lib/protocols/tls.c
index e4737829f..7ef8bdf1a 100644
--- a/src/lib/protocols/tls.c
+++ b/src/lib/protocols/tls.c
@@ -1687,7 +1687,8 @@ int processClientServerHello(struct ndpi_detection_module_struct *ndpi_struct,
while(s_offset < tot_alpn_len && s_offset < total_len) {
u_int8_t alpn_i, alpn_len = packet->payload[s_offset++];
- if((s_offset + alpn_len) <= tot_alpn_len) {
+ if((s_offset + alpn_len) <= tot_alpn_len &&
+ (s_offset + alpn_len) <= total_len) {
#ifdef DEBUG_TLS
printf("Client TLS [ALPN: %u]\n", alpn_len);
#endif
Powered by cgit, Themed by Ted Yin.