aboutsummaryrefslogtreecommitdiff
path: root/src/lib/protocols/tls.c
diff options
context:
space:
mode:
authoremanuele-f <black.silver@hotmail.it>2019-10-04 14:35:31 +0200
committeremanuele-f <black.silver@hotmail.it>2019-10-04 14:58:43 +0200
commit206ce0a317c63c61655b4b2dbce94b1dcdb8f965 (patch)
tree5396bba0e0b14d07888b474b4ebfca444f47ea41 /src/lib/protocols/tls.c
parent2184e0f7c27a77aad7e4231356f3ebabb7227a49 (diff)
Fix invalid memory accesses
Diffstat (limited to 'src/lib/protocols/tls.c')
-rw-r--r--src/lib/protocols/tls.c9
1 files changed, 7 insertions, 2 deletions
diff --git a/src/lib/protocols/tls.c b/src/lib/protocols/tls.c
index f621c2be3..cb4f7ac05 100644
--- a/src/lib/protocols/tls.c
+++ b/src/lib/protocols/tls.c
@@ -786,7 +786,12 @@ int getSSCertificateFingerprint(struct ndpi_detection_module_struct *ndpi_struct
#endif
return(1); /* More packets please */
}
- }
+ }
+
+ if(packet->payload_packet_len <= flow->l4.tcp.tls_record_offset) {
+ /* Avoid invalid memory accesses */
+ return(1);
+ }
if(packet->payload[flow->l4.tcp.tls_record_offset] == 0x15 /* Alert */) {
u_int len = ntohs(*(u_int16_t*)&packet->payload[flow->l4.tcp.tls_record_offset+3]) + 5 /* SSL header len */;
@@ -833,7 +838,7 @@ int getSSCertificateFingerprint(struct ndpi_detection_module_struct *ndpi_struct
return(0); /* That's all */
} else if(flow->l4.tcp.tls_seen_certificate)
return(0); /* That's all */
- else {
+ else if(packet->payload_packet_len > flow->l4.tcp.tls_record_offset+7) {
/* This is a handshake but not a certificate record */
u_int16_t len = ntohs(*(u_int16_t*)&packet->payload[flow->l4.tcp.tls_record_offset+7]);