diff options
| author | Michele Campus <fci1908@gmail.com> | 2016-04-12 23:41:02 +0200 |
|---|---|---|
| committer | Michele Campus <fci1908@gmail.com> | 2016-04-12 23:41:02 +0200 |
| commit | da811fbdd0023a0a3dc3f810029ef92e83e1f781 (patch) | |
| tree | 5e75a520f4c2f12ab85b22914f15c8f0857f132e /src/lib/protocols/starcraft.c | |
| parent | 885cc3864eccaa0eaadff7233f5a6a94c4239e24 (diff) | |
| parent | d7a2515093ce64d29020c0768956c6ead1ae23da (diff) | |
Merge pull request #173 from theirix/buffer-overflows
Fixed multiple buffer overflows
Diffstat (limited to 'src/lib/protocols/starcraft.c')
| -rw-r--r-- | src/lib/protocols/starcraft.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/src/lib/protocols/starcraft.c b/src/lib/protocols/starcraft.c index f96853f23..760578563 100644 --- a/src/lib/protocols/starcraft.c +++ b/src/lib/protocols/starcraft.c @@ -49,9 +49,8 @@ u_int8_t ndpi_check_starcraft_tcp(struct ndpi_detection_module_struct* ndpi_stru { if (sc2_match_logon_ip(&flow->packet) && flow->packet.tcp->dest == htons(1119) //bnetgame port - && flow->packet.payload_packet_len >= 10 - && (match_first_bytes(flow->packet.payload, "\x4a\x00\x00\x0a\x66\x02\x0a\xed\x2d\x66") - || match_first_bytes(flow->packet.payload, "\x49\x00\x00\x0a\x66\x02\x0a\xed\x2d\x66"))) + && (ndpi_match_strprefix(flow->packet.payload, flow->packet.payload_packet_len, "\x4a\x00\x00\x0a\x66\x02\x0a\xed\x2d\x66") + || ndpi_match_strprefix(flow->packet.payload, flow->packet.payload_packet_len, "\x49\x00\x00\x0a\x66\x02\x0a\xed\x2d\x66"))) return 1; else return -1; |